third_party/WebKit/Source/core/inspector/InspectorPageAgent.h - Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/protocol/page_handler.cc ('k') | third_party/WebKit/Source/core/inspector/InspectorPageAgent.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

diff --git a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

index 28f8e6a0a8c2710f306dcae797c8adc22f3bf8f2..e94c2555adc70644445a23c8414493ef4dbad6c8 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

+++ b/third_party/WebKit/Source/core/inspector/InspectorPageAgent.h

@@ -100,8 +100,7 @@ public:

void addScriptToEvaluateOnLoad(ErrorString*, const String& scriptSource, String* identifier) override;

void removeScriptToEvaluateOnLoad(ErrorString*, const String& identifier) override;

void setAutoAttachToCreatedPages(ErrorString*, bool autoAttach) override;

- // TODO(crbug.com/599364): Rename |ignoreCache| to |bypassCache|.

- void reload(ErrorString*, const Maybe<bool>& ignoreCache, const Maybe<String>& scriptToEvaluateOnLoad) override;

+ void reload(ErrorString*, const Maybe<bool>& bypassCache, const Maybe<String>& scriptToEvaluateOnLoad) override;

void navigate(ErrorString*, const String& url, String* frameId) override;

void getResourceTree(ErrorString*, OwnPtr<protocol::Page::FrameResourceTree>* frameTree) override;

void getResourceContent(ErrorString*, const String& frameId, const String& url, PassOwnPtr<GetResourceContentCallback>) override;