Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Side by Side Diff: chrome/test/chromedriver/chrome/web_view_impl.cc

Issue 1867523002: Rename ignore_cache and ignoreCache to bypass* unless it affects API (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2013 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/test/chromedriver/chrome/web_view_impl.h" 5 #include "chrome/test/chromedriver/chrome/web_view_impl.h"
6 6
7 #include <stddef.h> 7 #include <stddef.h>
8 #include <utility> 8 #include <utility>
9 9
10 #include "base/bind.h" 10 #include "base/bind.h"
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
184 if (base::StartsWith(url, "javascript:", 184 if (base::StartsWith(url, "javascript:",
185 base::CompareCase::INSENSITIVE_ASCII)) 185 base::CompareCase::INSENSITIVE_ASCII))
186 return Status(kUnknownError, "unsupported protocol"); 186 return Status(kUnknownError, "unsupported protocol");
187 base::DictionaryValue params; 187 base::DictionaryValue params;
188 params.SetString("url", url); 188 params.SetString("url", url);
189 return client_->SendCommand("Page.navigate", params); 189 return client_->SendCommand("Page.navigate", params);
190 } 190 }
191 191
192 Status WebViewImpl::Reload() { 192 Status WebViewImpl::Reload() {
193 base::DictionaryValue params; 193 base::DictionaryValue params;
194 // TODO(toyoshim): Check if this ignoreCache shouldn't be changed for
dgozman 2016/04/06 15:44:19 This is a public API usage as well.
Takashi Toyoshima 2016/04/08 04:50:54 Acknowledged.
195 // DevTools protocol.
194 params.SetBoolean("ignoreCache", false); 196 params.SetBoolean("ignoreCache", false);
195 return client_->SendCommand("Page.reload", params); 197 return client_->SendCommand("Page.reload", params);
196 } 198 }
197 199
198 Status WebViewImpl::TraverseHistory(int delta) { 200 Status WebViewImpl::TraverseHistory(int delta) {
199 base::DictionaryValue params; 201 base::DictionaryValue params;
200 scoped_ptr<base::DictionaryValue> result; 202 scoped_ptr<base::DictionaryValue> result;
201 Status status = client_->SendCommandAndGetResult( 203 Status status = client_->SendCommandAndGetResult(
202 "Page.getNavigationHistory", params, &result); 204 "Page.getNavigationHistory", params, &result);
203 if (status.IsError()) { 205 if (status.IsError()) {
(...skipping 649 matching lines...) Expand 10 before | Expand all | Expand 10 after
853 if (status.IsError()) 855 if (status.IsError())
854 return status; 856 return status;
855 857
856 if (!cmd_result->GetInteger("nodeId", node_id)) 858 if (!cmd_result->GetInteger("nodeId", node_id))
857 return Status(kUnknownError, "DOM.requestNode missing int 'nodeId'"); 859 return Status(kUnknownError, "DOM.requestNode missing int 'nodeId'");
858 *found_node = true; 860 *found_node = true;
859 return Status(kOk); 861 return Status(kOk);
860 } 862 }
861 863
862 } // namespace internal 864 } // namespace internal
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698