"Move to other window" improvements.

"Move to other window" improvements.

This makes several improvements and bug fixes to the unfinished "move to
other window" feature:
 - Unifies logic for tab detaching and activity launching.
   Tab.detachAndStartReparenting() now handles the process of detaching
   the tab from the current activity and launching the new host
   activity. This de-duplicates some logic that existed in
   CustomTabActivity and ChromeTabbedActivity.
 - Fixes white flicker when reparenting into an already-visible activity.
   See change in CompositorViewHolder.
 - Moving NativePages now works. ExternalNavigationDelegateImpl nows
   uses a better way to get the application context that works for
   native pages, and the intent now has trusted extras so
   chrome-native:// URLs will be accepted.
 - Various UI elements now update themselves correctly when a tab is moved:
     * ChromeTabbedActivity closes if homepage is enabled and the last tab
       was moved
     * The toolbar state (e.g. the tab count number) is updated when a
       tab is moved
     * The tablet empty background view is shown when the last tab is
       moved.

BUG=595889
Committed: https://crrev.com/9e77195b5ba9b99e62af0248e103add25eee3aad
Cr-Commit-Position: refs/heads/master@{#385916}

[newt (away), 2016-04-07 19:09:38]

newt@chromium.org changed reviewers:
+ yusufo@chromium.org

[newt (away), 2016-04-07 19:09:38]

PTAL

[Yusuf, 2016-04-07 19:15:13]

lgtm

 withy two nits

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:739:
final Tab tab = getActivityTab();
should we move this to the very top of this method? We seem to be calling this 3
times.

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
(right):

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java:125:
params.finalizeTabReparenting();
should we do this inside attachAndFinishReparenting?

[Yusuf, 2016-04-07 21:46:36]

Still lgtm!

[Yusuf, 2016-04-07 21:46:50]

The CQ bit was checked by yusufo@chromium.org

[newt (away), 2016-04-07 21:47:08]

Danke schoen!

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java
(right):

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java:739:
final Tab tab = getActivityTab();
On 2016/04/07 19:15:13, Yusuf wrote:
> should we move this to the very top of this method? We seem to be calling this
3
> times.

Done.

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
File
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java
(right):

https://codereview.chromium.org/1867083003/diff/1/chrome/android/java/src/org...
chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java:125:
params.finalizeTabReparenting();
On 2016/04/07 19:15:13, Yusuf wrote:
> should we do this inside attachAndFinishReparenting?

Seems reasonable. Done.

[commit-bot: I haz the power, 2016-04-07 21:47:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867083003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867083003/20001

[commit-bot: I haz the power, 2016-04-07 22:19:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 22:19:52]

Try jobs failed on following builders:
  android_clang_dbg_recipe on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[newt (away), 2016-04-07 22:24:59]

The CQ bit was checked by newt@chromium.org

[newt (away), 2016-04-07 22:25:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yusufo@chromium.org
Link to the patchset: https://codereview.chromium.org/1867083003/#ps40001
(title: "fix legit findbugs failure")

[commit-bot: I haz the power, 2016-04-07 22:25:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1867083003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1867083003/40001

[commit-bot: I haz the power, 2016-04-07 23:11:15]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 23:13:47]

Description was changed from

==========
"Move to other window" improvements.

This makes several improvements and bug fixes to the unfinished "move to
other window" feature:
 - Unifies logic for tab detaching and activity launching.
   Tab.detachAndStartReparenting() now handles the process of detaching
   the tab from the current activity and launching the new host
   activity. This de-duplicates some logic that existed in
   CustomTabActivity and ChromeTabbedActivity.
 - Fixes white flicker when reparenting into an already-visible activity.
   See change in CompositorViewHolder.
 - Moving NativePages now works. ExternalNavigationDelegateImpl nows
   uses a better way to get the application context that works for
   native pages, and the intent now has trusted extras so
   chrome-native:// URLs will be accepted.
 - Various UI elements now update themselves correctly when a tab is moved:
     * ChromeTabbedActivity closes if homepage is enabled and the last tab
       was moved
     * The toolbar state (e.g. the tab count number) is updated when a
       tab is moved
     * The tablet empty background view is shown when the last tab is
       moved.

BUG=595889
==========

to

==========
"Move to other window" improvements.

This makes several improvements and bug fixes to the unfinished "move to
other window" feature:
 - Unifies logic for tab detaching and activity launching.
   Tab.detachAndStartReparenting() now handles the process of detaching
   the tab from the current activity and launching the new host
   activity. This de-duplicates some logic that existed in
   CustomTabActivity and ChromeTabbedActivity.
 - Fixes white flicker when reparenting into an already-visible activity.
   See change in CompositorViewHolder.
 - Moving NativePages now works. ExternalNavigationDelegateImpl nows
   uses a better way to get the application context that works for
   native pages, and the intent now has trusted extras so
   chrome-native:// URLs will be accepted.
 - Various UI elements now update themselves correctly when a tab is moved:
     * ChromeTabbedActivity closes if homepage is enabled and the last tab
       was moved
     * The toolbar state (e.g. the tab count number) is updated when a
       tab is moved
     * The tablet empty background view is shown when the last tab is
       moved.

BUG=595889

Committed: https://crrev.com/9e77195b5ba9b99e62af0248e103add25eee3aad
Cr-Commit-Position: refs/heads/master@{#385916}
==========

[commit-bot: I haz the power, 2016-04-07 23:13:48]

Patchset 3 (id:??) landed as
https://crrev.com/9e77195b5ba9b99e62af0248e103add25eee3aad
Cr-Commit-Position: refs/heads/master@{#385916}