chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java - Issue 1867083003: "Move to other window" improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

Issue 1867083003: "Move to other window" improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@find_in_page_leak

Patch Set: fix legit findbugs failure Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabActivity.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/externalnav/ExternalNavigationDelegateImpl.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

index be561e00e37eb4bdb168477daa2a99af44104513..e38fb571d54b49c2595f857bf5a5583638608adf 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/document/DocumentActivity.java

@@ -54,6 +54,7 @@ import org.chromium.chrome.browser.tabmodel.AsyncTabParams;

import org.chromium.chrome.browser.tabmodel.AsyncTabParamsManager;

import org.chromium.chrome.browser.tabmodel.SingleTabModelSelector;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

+import org.chromium.chrome.browser.tabmodel.TabReparentingParams;

import org.chromium.chrome.browser.tabmodel.document.ActivityDelegate;

import org.chromium.chrome.browser.tabmodel.document.AsyncTabCreationParams;

import org.chromium.chrome.browser.tabmodel.document.DocumentTabModel;

@@ -611,7 +612,8 @@ public class DocumentActivity extends ChromeActivity {

if (params != null && params.getTabToReparent() != null) {

mTab = params.getTabToReparent();

- mTab.reparentToActivity(this, new DocumentTabDelegateFactory());

+ mTab.attachAndFinishReparenting(this, new DocumentTabDelegateFactory(),

+ (TabReparentingParams) params);

} else {

mTab = createActivityTab(asyncParams);

}