chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java - Issue 1867083003: "Move to other window" improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java

Issue 1867083003: "Move to other window" improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@find_in_page_leak

Patch Set: fix legit findbugs failure Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarManager.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java

index b75f13233b057c99edb00ea13a6f469b7b6e1e70..63d44f10832ee8b58fe9c2fc453ef16bd94ca886 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java

@@ -102,7 +102,7 @@ public interface TabModelObserver {

void allTabsClosureCommitted();

/**

- * Called when a tab is removed.

+ * Called after a tab has been removed. At this point, the tab is no longer in the tab model.

* @param tab The tab that has been removed.