chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java - Issue 1867083003: "Move to other window" improvements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

Issue 1867083003: "Move to other window" improvements. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@find_in_page_leak

Patch Set: fix legit findbugs failure Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/Tab.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelObserver.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

index d476c3c42a7af10d5c75e4e1bfb2c1c7153fe2b1..8f825f6b75cf7f725d6ed9a4a36ce29c83d3f94a 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/ChromeTabCreator.java

@@ -121,8 +121,7 @@ public class ChromeTabCreator extends TabCreatorManager.TabCreator {

TabReparentingParams params = (TabReparentingParams) asyncParams;

tab = params.getTabToReparent();

- tab.reparentToActivity(mActivity, new TabDelegateFactory());

- params.finalizeTabReparenting();

+ tab.attachAndFinishReparenting(mActivity, new TabDelegateFactory(), params);

} else if (asyncParams != null && asyncParams.getWebContents() != null) {

openInForeground = true;

WebContents webContents = asyncParams.getWebContents();