Subzero: Improve non-MINIMAL string performance.

Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator performance has regressed as a result of 467ffe51bebcb3ae3e3ce745c38fc20e8837c31c (https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand.  Note that it should have no effect on MINIMAL build performance.

Also, it turns out that Variable::getName() does not really need the Cfg* parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
R=jpp@chromium.org, kschimpf@google.com

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=a91c34118294efbf08ebd11eed96fce83bf35f3c

[Jim Stichnoth, 2016-04-05 21:53:02]

Description was changed from

==========
Subzero: Improve non-MINIMAL string performance.

BUG= none
==========

to

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

BUG= none
==========

[Jim Stichnoth, 2016-04-05 21:59:26]

Description was changed from

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

BUG= none
==========

to

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each
other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
==========

[Jim Stichnoth, 2016-04-05 21:59:26]

stichnot@chromium.org changed reviewers:
+ eholk@chromium.org, jpp@chromium.org, kschimpf@google.com, sehr@chromium.org

[Jim Stichnoth, 2016-04-05 22:00:11]

Description was changed from

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each
other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
==========

to

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand. 
Note that it should have no effect on MINIMAL build performance.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each
other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
==========

[Karl, 2016-04-05 22:06:20]

lgtm

[John, 2016-04-05 22:08:00]

lgtm

[Jim Stichnoth, 2016-04-05 22:32:12]

Description was changed from

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand. 
Note that it should have no effect on MINIMAL build performance.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each
other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
==========

to

==========
Subzero: Improve non-MINIMAL string performance.

In a DUMP-enabled build, such as the standard Release+Asserts build, translator
performance has regressed as a result of
467ffe51bebcb3ae3e3ce745c38fc20e8837c31c
(https://codereview.chromium.org/1838753002).

This is because Variable and CfgNode names are being instantiated
unconditionally, rather than on-demand.

This CL restores most of that performance by going back to being on-demand. 
Note that it should have no effect on MINIMAL build performance.

Also, it turns out that Variable::getName() does not really need the Cfg*
parameter, so that is removed (and all its callers are fixed transitively).

In addition, Variable and CfgNode are made more uniform with respect to each
other in terms of inline definitions of the ctor, getName(), and setName().

BUG= none
R=jpp@chromium.org, kschimpf@google.com

Committed:
https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a...
==========

[Jim Stichnoth, 2016-04-05 22:32:13]

Committed patchset #1 (id:1) manually as
a91c34118294efbf08ebd11eed96fce83bf35f3c (presubmit successful).