Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: src/IceOperand.cpp

Issue 1866463002: Subzero: Improve non-MINIMAL string performance. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceOperand.h ('k') | src/IceRegAlloc.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceOperand.cpp
diff --git a/src/IceOperand.cpp b/src/IceOperand.cpp
index 462ba9a615cf6e874c5d1fe589aa7db370bf0609..50d70b935cd761ff5f0a67a34cb5f912f84aa6cf 100644
--- a/src/IceOperand.cpp
+++ b/src/IceOperand.cpp
@@ -191,12 +191,6 @@ void LiveRange::trim(InstNumberT Lower) {
++TrimmedBegin;
}
-std::string Variable::getName(const Cfg *Func) const {
- if (Func == nullptr)
- return "__" + std::to_string(getIndex());
- return Name.toString();
-}
-
const Variable *Variable::asType(const Cfg *Func, Type Ty,
RegNumT NewRegNum) const {
// Note: This returns a Variable, even if the "this" object is a subclass of
@@ -539,12 +533,12 @@ void Variable::dump(const Cfg *Func, Ostream &Str) const {
if (!BuildDefs::dump())
return;
if (Func == nullptr) {
- Str << "%" << getName(Func);
+ Str << "%" << getName();
return;
}
if (Func->isVerbose(IceV_RegOrigins) ||
(!hasReg() && !Func->getTarget()->hasComputedFrame()))
- Str << "%" << getName(Func);
+ Str << "%" << getName();
if (hasReg()) {
if (Func->isVerbose(IceV_RegOrigins))
Str << ":";
« no previous file with comments | « src/IceOperand.h ('k') | src/IceRegAlloc.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698