Remove unused features for in-process GL contexts.

Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/079252237cd59e2f00089976852366c50fe3d778
Cr-Commit-Position: refs/heads/master@{#385859}

[danakj, 2016-04-06 22:46:05]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

[danakj, 2016-04-06 22:46:05]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel;tryserver.chromium.win:win_optional_gpu_tests_rel
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-06 22:58:56]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:00:25]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/20001

[danakj, 2016-04-06 23:01:06]

danakj@chromium.org changed reviewers:
+ boliu@chromium.org

[danakj, 2016-04-06 23:01:06]

+bo for webview

[danakj, 2016-04-06 23:01:10]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[danakj, 2016-04-06 23:01:49]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[danakj, 2016-04-06 23:01:49]

danakj@chromium.org changed reviewers:
+ piman@chromium.org
- piman@chomium.org

[commit-bot: I haz the power, 2016-04-06 23:02:42]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/60001

[danakj, 2016-04-06 23:04:34]

Oh, some changes needed for ui compositor unittests.

[boliu, 2016-04-06 23:05:38]

On 2016/04/06 23:01:06, danakj wrote:
> +bo for webview

Context loss is used... To crash webview with a stable signature in the output
surface.

[danakj, 2016-04-06 23:07:01]

On Wed, Apr 6, 2016 at 4:05 PM, <boliu@chromium.org> wrote:

> On 2016/04/06 23:01:06, danakj wrote:
> > +bo for webview
>
> Context loss is used... To crash webview with a stable signature in the
> output
> surface.
>

Oh, ok can you point me where?


>
> https://codereview.chromium.org/1864373002/
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-06 23:12:27]

On Wed, Apr 6, 2016 at 4:06 PM, Dana Jansens <danakj@chromium.org> wrote:

> On Wed, Apr 6, 2016 at 4:05 PM, <boliu@chromium.org> wrote:
>
>> On 2016/04/06 23:01:06, danakj wrote:
>> > +bo for webview
>>
>> Context loss is used... To crash webview with a stable signature in the
>> output
>> surface.
>>
>
> Oh, ok can you point me where?
>

Ah, got it:

void ParentOutputSurface::DidLoseOutputSurface() {
  // Android WebView does not handle context loss.

  LOG(FATAL) << "Render thread context loss";
}



>
>
>>
>> https://codereview.chromium.org/1864373002/
>>
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[danakj, 2016-04-06 23:13:01]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:14:01]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/80001

[boliu, 2016-04-06 23:14:54]

On 2016/04/06 23:12:27, danakj wrote:
> On Wed, Apr 6, 2016 at 4:06 PM, Dana Jansens <mailto:danakj@chromium.org>
wrote:
> 
> > On Wed, Apr 6, 2016 at 4:05 PM, <mailto:boliu@chromium.org> wrote:
> >
> >> On 2016/04/06 23:01:06, danakj wrote:
> >> > +bo for webview
> >>
> >> Context loss is used... To crash webview with a stable signature in the
> >> output
> >> surface.
> >>
> >
> > Oh, ok can you point me where?
> >
> 
> Ah, got it:
> 
> void ParentOutputSurface::DidLoseOutputSurface() {
>   // Android WebView does not handle context loss.
> 
>   LOG(FATAL) << "Render thread context loss";
> }
> 

Yep.. cs not very accessible from phone

> 
> 
> >
> >
> >>
> >> https://codereview.chromium.org/1864373002/
> >>
> >
> >
> 
> -- 
> You received this message because you are subscribed to the Google Groups
> "Chromium-reviews" group.
> To unsubscribe from this group and stop receiving emails from it, send an
email
> to mailto:chromium-reviews+unsubscribe@chromium.org.

[no sievers, 2016-04-06 23:17:23]

https://codereview.chromium.org/1864373002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/in_process_command_buffer.cc (right):

https://codereview.chromium.org/1864373002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/in_process_command_buffer.cc:241:
command_buffer_->SetParseError(gpu::error::kLostContext);
return false;

[danakj, 2016-04-06 23:24:44]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Lost context callbacks
- Global share group
- Context lock

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.


R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-06 23:27:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-06 23:27:40]

Dry run: Try jobs failed on following builders:
  android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_chro...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[danakj, 2016-04-06 23:29:37]

danakj@chromium.org changed reviewers:
+ wez@chromium.org

[danakj, 2016-04-06 23:29:38]

PTAL. Restored the lost callback, and fixed some more targets.

+wez for blimp/

https://codereview.chromium.org/1864373002/diff/60001/gpu/command_buffer/serv...
File gpu/command_buffer/service/in_process_command_buffer.cc (right):

https://codereview.chromium.org/1864373002/diff/60001/gpu/command_buffer/serv...
gpu/command_buffer/service/in_process_command_buffer.cc:241:
command_buffer_->SetParseError(gpu::error::kLostContext);
On 2016/04/06 23:17:23, sievers wrote:
> return false;

Oops thanks.

[danakj, 2016-04-06 23:29:59]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:30:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/100001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/100001

[danakj, 2016-04-06 23:44:42]

https://codereview.chromium.org/1864373002/diff/100001/gpu/command_buffer/ser...
File gpu/command_buffer/service/in_process_command_buffer.cc (left):

https://codereview.chromium.org/1864373002/diff/100001/gpu/command_buffer/ser...
gpu/command_buffer/service/in_process_command_buffer.cc:327:
command_buffer->SetParseErrorCallback(base::Bind(
Oops, gotta put this back too. :) Done.

[danakj, 2016-04-06 23:45:02]

The CQ bit was checked by danakj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-06 23:46:12]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/120001

[no sievers, 2016-04-07 00:19:14]

lgtm

[piman, 2016-04-07 00:26:06]

https://codereview.chromium.org/1864373002/diff/120001/ui/compositor/test/in_...
File ui/compositor/test/in_process_context_factory.cc (right):

https://codereview.chromium.org/1864373002/diff/120001/ui/compositor/test/in_...
ui/compositor/test/in_process_context_factory.cc:193:
&gpu_memory_buffer_manager_, &image_factory_, nullptr);
Do we not need this to share with the other contexts?

[Wez, 2016-04-07 00:26:42]

blimp/ LGTM

[boliu, 2016-04-07 01:11:16]

android_webview lgtm

[commit-bot: I haz the power, 2016-04-07 03:08:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 03:08:42]

Dry run: This issue passed the CQ dry run.

[danakj, 2016-04-07 18:58:59]

https://codereview.chromium.org/1864373002/diff/120001/ui/compositor/test/in_...
File ui/compositor/test/in_process_context_factory.cc (right):

https://codereview.chromium.org/1864373002/diff/120001/ui/compositor/test/in_...
ui/compositor/test/in_process_context_factory.cc:193:
&gpu_memory_buffer_manager_, &image_factory_, nullptr);
On 2016/04/07 00:26:06, piman wrote:
> Do we not need this to share with the other contexts?

Everything is mailboxed (in our tests?) I don't think we actually need this to
share, can you think of anything? I was going to say maybe reflector but it's
mailboxed now too.

[piman, 2016-04-07 20:16:19]

ok, lgtm then

[danakj, 2016-04-07 20:17:46]

The CQ bit was checked by danakj@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:18:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1864373002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1864373002/120001

[commit-bot: I haz the power, 2016-04-07 21:19:36]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.


R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.


R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

[commit-bot: I haz the power, 2016-04-07 21:19:38]

Committed patchset #7 (id:120001)

[commit-bot: I haz the power, 2016-04-07 21:29:46]

Description was changed from

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.


R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
==========

to

==========
Remove unused features for in-process GL contexts.

These features are not used and need not be supported:
- Global share group
- Context lock

Also cleans up GLInProcessContext to not require tracking lost
context state, so that we can have users of GLES2Implementation
get lost context notifications directly, going past the
GLInProcessContext.

R=piman@chomium.org, sievers@chromium.org
BUG=584497
CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel

Committed: https://crrev.com/079252237cd59e2f00089976852366c50fe3d778
Cr-Commit-Position: refs/heads/master@{#385859}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:48]

Patchset 7 (id:??) landed as
https://crrev.com/079252237cd59e2f00089976852366c50fe3d778
Cr-Commit-Position: refs/heads/master@{#385859}