Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1864243004: Remove RawPtr from Source/modules Part 2 (Closed)

Created:
4 years, 8 months ago by keishi
Modified:
4 years, 8 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tyoshino+watch_chromium.org, serviceworker-reviews, toyoshim+midi_chromium.org, mvanouwerkerk+watch_chromium.org, Peter Beverloo, johnme+watch_chromium.org, tzik, nhiroki, Raymond Toy, falken, kinuko+serviceworker, horo+watch_chromium.org, blink-reviews, gyuyoung2, hongchan, harkness+watch_chromium.org, kinuko+fileapi, yhirano+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove RawPtr from Source/modules Part 2 BUG=585328 CQ_INCLUDE_TRYBOTS=tryserver.chromium.win:win_optional_gpu_tests_rel;tryserver.chromium.mac:mac_optional_gpu_tests_rel Committed: https://crrev.com/ef79441ba88117dcfcb7b7795c942ea9b58d383b Cr-Commit-Position: refs/heads/master@{#385730}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -182 lines) Patch
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtils.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/NavigatorContentUtilsClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/navigatorcontentutils/testing/NavigatorContentUtilsClientMock.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/notifications/NotificationPermissionClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvas.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas/OffscreenCanvasRenderingContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/payments/PaymentRequest.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionAvailableEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationConnectionCloseEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/presentation/PresentationController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/push_messaging/PushEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/quota/StorageQuotaClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.h View 1 chunk +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ExtendableMessageEvent.cpp View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/FetchEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/InstallEvent.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerContainerClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScope.cpp View 4 chunks +11 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerGlobalScopeClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerLinkResource.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerMessageEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/serviceworkers/ServiceWorkerScriptCachedMetadataHandler.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionError.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionError.cpp View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.h View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechRecognitionEvent.cpp View 1 chunk +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/speech/SpeechSynthesisEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/storage/StorageEvent.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioProcessingEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/AudioScheduledSourceNode.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webaudio/OfflineAudioCompletionEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseClient.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/DatabaseClient.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webdatabase/InspectorDatabaseAgent.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContext.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 3 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLContextEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 4 chunks +5 lines, -11 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIConnectionEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIController.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIController.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIInput.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webmidi/MIDIMessageEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/CloseEvent.h View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/websockets/DOMWebSocket.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConnectionEvent.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webusb/USBConnectionEvent.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
keishi
PTAL
4 years, 8 months ago (2016-04-07 11:33:20 UTC) #3
haraken
LGTM
4 years, 8 months ago (2016-04-07 11:35:27 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864243004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864243004/1
4 years, 8 months ago (2016-04-07 11:41:18 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 12:50:47 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 12:52:09 UTC) #9
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/ef79441ba88117dcfcb7b7795c942ea9b58d383b
Cr-Commit-Position: refs/heads/master@{#385730}

Powered by Google App Engine
This is Rietveld 408576698