Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(228)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers (Closed)

Created:
4 years, 8 months ago by xlai (Olivia)
Modified:
4 years, 8 months ago
Reviewers:
esprehn, Justin Novosad
CC:
ajuma+watch-canvas_chromium.org, darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-animation_chromium.org, blink-reviews-css, blink-reviews-dom_chromium.org, blink-reviews-html_chromium.org, blink-reviews-style_chromium.org, Rik, chromium-reviews, dglazkov+blink, dshwang, krit, eae+blinkwatch, Eric Willigers, f(malita), fs, gyuyoung2, haraken, Justin Novosad, kouhei+svg_chromium.org, pdr+svgwatchlist_chromium.org, rjwright, rwlbuis, Stephen Chennney, shans, sof
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make CSSValuePool thread local to ensure correct parsing in colors on workers We make each worker thread to have its own CSSValuePool (lazily initialized), by making CSSValuePool to be a member in ExecutionContext. COMMIT=false BUG=599659

Patch Set 1 #

Patch Set 2 : Rebase with master #

Unified diffs Side-by-side diffs Delta from patch set Stats (+65 lines, -33 lines) Patch
M third_party/WebKit/Source/core/css/CSSValuePool.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/CSSValuePool.cpp View 1 2 chunks +1 line, -8 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParser.cpp View 2 chunks +8 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h View 2 chunks +3 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/dom/Document.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.h View 1 3 chunks +6 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/dom/ExecutionContext.cpp View 1 1 chunk +13 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/editing/EditingStyle.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/html/HTMLBodyElement.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h View 2 chunks +2 lines, -1 line 0 comments Download
M third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp View 1 chunk +8 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/offscreencanvas2d/OffscreenCanvasRenderingContext2D.cpp View 2 chunks +9 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebCSSParser.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/tests/sim/SimDisplayItemList.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (3 generated)
esprehn
4 years, 8 months ago (2016-04-06 21:02:09 UTC) #3 
Lets use a ThreadSpecific to start. Otherwise we should plumb the pool all over
and remove the static one, not have a special case localValuePool like you've
done here.

Powered by Google App Engine
This is Rietveld 408576698