third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h - Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h

Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/svg/SVGAnimatedColor.cpp ('k') | third_party/WebKit/Source/modules/canvas2d/CanvasStyle.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h

diff --git a/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h b/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h

index 02923de261e0b797aa6490de60e86a436b1de2b5..e182e295bf582989f30f166889416861be090a53 100644

--- a/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h

+++ b/third_party/WebKit/Source/modules/canvas2d/CanvasStyle.h

@@ -27,6 +27,7 @@

#ifndef CanvasStyle_h

#define CanvasStyle_h

+#include "core/css/CSSValuePool.h"

#include "platform/graphics/Color.h"

#include "platform/heap/Handle.h"

#include "wtf/Assertions.h"

@@ -73,7 +74,7 @@ private:

Member<CanvasPattern> m_pattern;

};

-bool parseColorOrCurrentColor(Color& parsedColor, const String& colorString, HTMLCanvasElement*);

+bool parseColorOrCurrentColor(Color& parsedColor, const String& colorString, HTMLCanvasElement*, CSSValuePool* localCssValuePool = nullptr);

} // namespace blink