Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Side by Side Diff: third_party/WebKit/Source/core/css/CSSValuePool.h

Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase with master Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSValuePool.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved. 2 * Copyright (C) 2011, 2012 Apple Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
55 RawPtr<CSSCustomIdentValue> createIdentifierValue(CSSPropertyID identifier); 55 RawPtr<CSSCustomIdentValue> createIdentifierValue(CSSPropertyID identifier);
56 RawPtr<CSSColorValue> createColorValue(RGBA32 rgbValue); 56 RawPtr<CSSColorValue> createColorValue(RGBA32 rgbValue);
57 RawPtr<CSSPrimitiveValue> createValue(double value, CSSPrimitiveValue::UnitT ype); 57 RawPtr<CSSPrimitiveValue> createValue(double value, CSSPrimitiveValue::UnitT ype);
58 RawPtr<CSSPrimitiveValue> createValue(const Length& value, const ComputedSty le&); 58 RawPtr<CSSPrimitiveValue> createValue(const Length& value, const ComputedSty le&);
59 RawPtr<CSSPrimitiveValue> createValue(const Length& value, float zoom) { ret urn CSSPrimitiveValue::create(value, zoom); } 59 RawPtr<CSSPrimitiveValue> createValue(const Length& value, float zoom) { ret urn CSSPrimitiveValue::create(value, zoom); }
60 template<typename T> static RawPtr<CSSPrimitiveValue> createValue(T value) { return CSSPrimitiveValue::create(value); } 60 template<typename T> static RawPtr<CSSPrimitiveValue> createValue(T value) { return CSSPrimitiveValue::create(value); }
61 61
62 DECLARE_TRACE(); 62 DECLARE_TRACE();
63 63
64 private: 64 private:
65 friend class ExecutionContext;
65 CSSValuePool(); 66 CSSValuePool();
66 67
67 Member<CSSInheritedValue> m_inheritedValue; 68 Member<CSSInheritedValue> m_inheritedValue;
68 Member<CSSInitialValue> m_implicitInitialValue; 69 Member<CSSInitialValue> m_implicitInitialValue;
69 Member<CSSInitialValue> m_explicitInitialValue; 70 Member<CSSInitialValue> m_explicitInitialValue;
70 Member<CSSUnsetValue> m_unsetValue; 71 Member<CSSUnsetValue> m_unsetValue;
71 72
72 HeapVector<Member<CSSPrimitiveValue>, numCSSValueKeywords> m_identifierValue Cache; 73 HeapVector<Member<CSSPrimitiveValue>, numCSSValueKeywords> m_identifierValue Cache;
73 74
74 using ColorValueCache = HeapHashMap<unsigned, Member<CSSColorValue>>; 75 using ColorValueCache = HeapHashMap<unsigned, Member<CSSColorValue>>;
(...skipping 15 matching lines...) Expand all
90 FontFamilyValueCache m_fontFamilyValueCache; 91 FontFamilyValueCache m_fontFamilyValueCache;
91 92
92 friend CORE_EXPORT CSSValuePool& cssValuePool(); 93 friend CORE_EXPORT CSSValuePool& cssValuePool();
93 }; 94 };
94 95
95 CORE_EXPORT CSSValuePool& cssValuePool(); 96 CORE_EXPORT CSSValuePool& cssValuePool();
96 97
97 } // namespace blink 98 } // namespace blink
98 99
99 #endif 100 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/css/CSSValuePool.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698