third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h - Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h

Issue 1863793003: Make CSSValuePool thread local to ensure correct parsing in colors on workers (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase with master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/css/parser/CSSParser.cpp ('k') | third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h

index 5d43a5cfd2872926629e507dcbba8e2840439872..fd0c4b1308a8e105a575c6b328a10ba69799c47a 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSParserFastPaths.h

@@ -7,6 +7,7 @@

#include "core/CSSPropertyNames.h"

#include "core/CSSValueKeywords.h"

+#include "core/css/CSSValuePool.h"

#include "platform/graphics/Color.h"

#include "platform/heap/Handle.h"

#include "wtf/Allocator.h"

@@ -21,13 +22,13 @@ class CSSParserFastPaths {

public:

// Parses simple values like '10px' or 'green', but makes no guarantees

// about handling any property completely.

- static RawPtr<CSSValue> maybeParseValue(CSSPropertyID, const String&, CSSParserMode);

+ static RawPtr<CSSValue> maybeParseValue(CSSPropertyID, const String&, CSSParserMode, CSSValuePool* localCSSValuePool = nullptr);

// Properties handled here shouldn't be explicitly handled in CSSPropertyParser

static bool isKeywordPropertyID(CSSPropertyID);

static bool isValidKeywordPropertyAndValue(CSSPropertyID, CSSValueID);

- static RawPtr<CSSValue> parseColor(const String&, CSSParserMode);

+ static RawPtr<CSSValue> parseColor(const String&, CSSParserMode, CSSValuePool*);

};

} // namespace blink