DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages

DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman

Committed: https://crrev.com/1d413c3ebced31d7182b31ff6efb458c5a12216e
Cr-Commit-Position: refs/heads/master@{#385872}

[lushnikov, 2016-04-07 00:23:00]

ptal

[lushnikov, 2016-04-07 00:23:06]

The CQ bit was checked by lushnikov@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-04-07 00:23:44]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863313002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863313002/1

[dgozman, 2016-04-07 00:40:12]

https://codereview.chromium.org/1863313002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right):

https://codereview.chromium.org/1863313002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:446:
this.element.scrollTop = this.element.scrollHeight;
Let's replace scrollHeight with 10000000000.

[lushnikov, 2016-04-07 00:53:27]

Description was changed from

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. We scroll viewport control to bottom even in case of non-invalidation.
   This works because the smooth scrolling advances scroll for a value greater
   then 1.

BUG=594339
R=dgozman, pfeldman
==========

to

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman
==========

[lushnikov, 2016-04-07 00:54:25]

https://codereview.chromium.org/1863313002/diff/1/third_party/WebKit/Source/d...
File third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js (right):

https://codereview.chromium.org/1863313002/diff/1/third_party/WebKit/Source/d...
third_party/WebKit/Source/devtools/front_end/ui/ViewportControl.js:446:
this.element.scrollTop = this.element.scrollHeight;
On 2016/04/07 00:40:12, dgozman wrote:
> Let's replace scrollHeight with 10000000000.

Done.

[dgozman, 2016-04-07 00:58:50]

lgtm

[dgozman, 2016-04-07 00:58:55]

The CQ bit was checked by dgozman@chromium.org

[commit-bot: I haz the power, 2016-04-07 00:59:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863313002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863313002/20001

[commit-bot: I haz the power, 2016-04-07 02:10:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 02:10:33]

Try jobs failed on following builders:
  linux_blink_oilpan_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_blink_oil...)

[lushnikov, 2016-04-07 17:24:33]

The CQ bit was checked by lushnikov@chromium.org

[lushnikov, 2016-04-07 17:24:33]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1863313002/#ps40001
(title: "fix test")

[commit-bot: I haz the power, 2016-04-07 17:24:48]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863313002/40001

[commit-bot: I haz the power, 2016-04-07 20:02:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:02:51]

Try jobs failed on following builders:
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[lushnikov, 2016-04-07 20:06:19]

The CQ bit was checked by lushnikov@chromium.org

[commit-bot: I haz the power, 2016-04-07 20:06:47]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1863313002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1863313002/40001

[commit-bot: I haz the power, 2016-04-07 21:28:53]

Description was changed from

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman
==========

to

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman
==========

[commit-bot: I haz the power, 2016-04-07 21:28:54]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-04-07 21:31:03]

Description was changed from

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman
==========

to

==========
DevTools: [Console] fix console stick-to-bottom behavior in case of multiline
messages

The patch fixes the stick-to-bottom behavior of console in case of multiline
messages.

The patch does two things:
1. ViewportControl starts to cache provider's itemCount in invalidate call.
   This ensures that the regular scrolling of viewport is not affected
   by provider's item changes unless an invalidate method was called.

2. Stick to bottom only in case of non-user-generated gestures. This is
   done via transitioning to the event.isTrusted flag.

BUG=594339
R=dgozman, pfeldman

Committed: https://crrev.com/1d413c3ebced31d7182b31ff6efb458c5a12216e
Cr-Commit-Position: refs/heads/master@{#385872}
==========

[commit-bot: I haz the power, 2016-04-07 21:31:04]

Patchset 3 (id:??) landed as
https://crrev.com/1d413c3ebced31d7182b31ff6efb458c5a12216e
Cr-Commit-Position: refs/heads/master@{#385872}