Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(393)

Side by Side Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

Issue 1863313002: DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 <html> 1 <html>
2 <head> 2 <head>
3 <script src="../../http/tests/inspector/inspector-test.js"></script> 3 <script src="../../http/tests/inspector/inspector-test.js"></script>
4 <script src="../../http/tests/inspector/console-test.js"></script> 4 <script src="../../http/tests/inspector/console-test.js"></script>
5 <script> 5 <script>
6 function populateConsoleWithMessages(count) 6 function populateConsoleWithMessages(count)
7 { 7 {
8 for (var i = 0; i < count - 1; ++i) 8 for (var i = 0; i < count - 1; ++i)
9 console.log("Message #" + i); 9 console.log("Multiline\nMessage #" + i);
10 console.log("hello %cworld", "color: blue"); 10 console.log("hello %cworld", "color: blue");
11 } 11 }
12 12
13 //# sourceURL=console-viewport-selection.html 13 //# sourceURL=console-viewport-selection.html
14 </script> 14 </script>
15 15
16 <script> 16 <script>
17 17
18 function test() 18 function test()
19 { 19 {
(...skipping 39 matching lines...) Expand 10 before | Expand all | Expand 10 after
59 viewport.invalidate(); 59 viewport.invalidate();
60 // Force refresh which has been scheduled via invalidate() metho d. 60 // Force refresh which has been scheduled via invalidate() metho d.
61 viewport.refresh(); 61 viewport.refresh();
62 InspectorTest.addResult("Last visible message: " + viewport.last VisibleIndex()); 62 InspectorTest.addResult("Last visible message: " + viewport.last VisibleIndex());
63 next(); 63 next();
64 } 64 }
65 }, 65 },
66 66
67 function testManualScrollDoesNotStickToBottom(next) 67 function testManualScrollDoesNotStickToBottom(next)
68 { 68 {
69 const manualScrollValue = 3;
69 var initialScrollTop = viewport.element.scrollTop; 70 var initialScrollTop = viewport.element.scrollTop;
70 viewport.element.scrollTop = initialScrollTop - 1; 71 viewport.element.scrollTop = initialScrollTop - manualScrollValue;
71 viewport.refresh(); 72 viewport._innerRefresh(true);
72 var newScrollTop = viewport.element.scrollTop; 73 var newScrollTop = viewport.element.scrollTop;
73 var isScrollPreserved = initialScrollTop - newScrollTop === 1; 74 var isScrollPreserved = initialScrollTop - newScrollTop === manualSc rollValue;
74 InspectorTest.addResult("Scroll preserved: " + isScrollPreserved); 75 InspectorTest.addResult("Scroll preserved: " + isScrollPreserved);
75 next(); 76 next();
76 }, 77 },
77 ]; 78 ];
78 79
79 function logMessagesToConsole(count, callback) 80 function logMessagesToConsole(count, callback)
80 { 81 {
81 var awaitingMessagesCount = count; 82 var awaitingMessagesCount = count;
82 function messageAdded() 83 function messageAdded()
83 { 84 {
84 if (!--awaitingMessagesCount) 85 if (!--awaitingMessagesCount)
85 callback(); 86 callback();
86 else 87 else
87 InspectorTest.addConsoleSniffer(messageAdded, false); 88 InspectorTest.addConsoleSniffer(messageAdded, false);
88 } 89 }
89 90
90 InspectorTest.addConsoleSniffer(messageAdded, false); 91 InspectorTest.addConsoleSniffer(messageAdded, false);
91 InspectorTest.evaluateInPage(String.sprintf("populateConsoleWithMessages (%d)", count)); 92 InspectorTest.evaluateInPage(String.sprintf("populateConsoleWithMessages (%d)", count));
92 } 93 }
93 } 94 }
94 </script> 95 </script>
95 </head> 96 </head>
96 <body onload="runTest()"> 97 <body onload="runTest()">
97 <p> 98 <p>
98 Verifies viewport stick-to-bottom behavior. 99 Verifies viewport stick-to-bottom behavior.
99 </p> 100 </p>
100 </body> 101 </body>
101 </html> 102 </html>
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698