Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html

Issue 1863313002: DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
index 3a11b687c15437430fa3a4699071a4a5141f7570..7dd3b13f39c48a3009e1e1efffb5cfa1e386d8a6 100644
--- a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
+++ b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html
@@ -97,7 +97,7 @@ function test()
function testScrollSelectionAwayDown(next)
{
consoleView._immediatelyScrollToBottom();
- viewport.refresh();
+ viewport._innerRefresh(true);
dumpSelectionModel();
dumpViewportRenderedItems();
next();
@@ -204,21 +204,21 @@ function test()
function dumpSelectionModel()
{
- viewport.refresh();
+ viewport._innerRefresh(true);
var text = String.sprintf("anchor = %s, head = %s", dumpSelectionModelElement(viewport._anchorSelection), dumpSelectionModelElement(viewport._headSelection));
InspectorTest.addResult(text);
}
function dumpSelectionText()
{
- viewport.refresh();
+ viewport._innerRefresh(true);
var text = viewport._selectedText();
InspectorTest.addResult("Selected text:<<<EOL\n" + text + "\nEOL");
}
function dumpViewportRenderedItems()
{
- viewport.refresh();
+ viewport._innerRefresh(true);
var firstVisibleIndex = viewport.firstVisibleIndex();
var lastVisibleIndex = viewport.lastVisibleIndex();
InspectorTest.addResult("first visible message index: " + firstVisibleIndex);
@@ -226,7 +226,7 @@ function test()
function emulateShiftClickOnMessage(messageIndex)
{
- viewport.refresh();
+ viewport._innerRefresh(true);
var selection = window.getSelection();
if (!selection || !selection.rangeCount) {
InspectorTest.addResult("FAILURE: There's no selection");
@@ -235,7 +235,7 @@ function test()
viewport.forceScrollItemToBeFirst(Math.max(messageIndex - minimumViewportMessagesCount / 2, 0));
var element = consoleView.itemElement(messageIndex).element();
selection.setBaseAndExtent(selection.anchorNode, selection.anchorOffset, element, 0);
- viewport.refresh();
+ viewport._innerRefresh(true);
}
function selectionContainerAndOffset(container, offset)
@@ -267,7 +267,7 @@ function test()
var from = selectionContainerAndOffset(consoleView.itemElement(fromMessage).element(), fromTextOffset);
var to = selectionContainerAndOffset(consoleView.itemElement(toMessage).element(), toTextOffset);
window.getSelection().setBaseAndExtent(from.container, from.offset, to.container, to.offset);
- viewport.refresh();
+ viewport._innerRefresh(true);
}
}
</script>
« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698