third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html - Issue 1863313002: DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

Issue 1863313002: DevTools: [Console] fix console stick-to-bottom behavior in case of multiline messages (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/inspector/console/console-viewport-selection.html ('k') | third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

diff --git a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

index 1d62c5a7ed8ea3418a2033a62c5e21e804cccb64..9a5004ec0b32b487d6a3fbe9face72be99c37347 100644

--- a/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

+++ b/third_party/WebKit/LayoutTests/inspector/console/console-viewport-stick-to-bottom.html

@@ -6,7 +6,7 @@

function populateConsoleWithMessages(count)

{

for (var i = 0; i < count - 1; ++i)

- console.log("Message #" + i);

+ console.log("Multiline\nMessage #" + i);

console.log("hello %cworld", "color: blue");

}

@@ -66,11 +66,12 @@ function test()

function testManualScrollDoesNotStickToBottom(next)

{

+ const manualScrollValue = 3;

var initialScrollTop = viewport.element.scrollTop;

- viewport.element.scrollTop = initialScrollTop - 1;

- viewport.refresh();

+ viewport.element.scrollTop = initialScrollTop - manualScrollValue;

+ viewport._innerRefresh(true);

var newScrollTop = viewport.element.scrollTop;

- var isScrollPreserved = initialScrollTop - newScrollTop === 1;

+ var isScrollPreserved = initialScrollTop - newScrollTop === manualScrollValue;

InspectorTest.addResult("Scroll preserved: " + isScrollPreserved);

next();