Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Issue 1863213004: [NTP Snippets] Cleanup: remove NTPSnippetsService::is_loaded() (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] Cleanup: remove NTPSnippetsService::is_loaded() It's now essentially always true, and it wasn't all that useful to begin with. BUG=none Committed: https://crrev.com/4f3a2f39c45a4af0f05fd3ffde6c040db01a74e9 Cr-Commit-Position: refs/heads/master@{#385766}

Patch Set 1 #

Patch Set 2 : tests #

Patch Set 3 : remove now-pointless tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -89 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 5 chunks +6 lines, -21 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +1 line, -5 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service_unittest.cc View 1 2 4 chunks +0 lines, -60 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (6 generated)
Marc Treib
Small cleanup. PTAL!
4 years, 8 months ago (2016-04-07 13:53:23 UTC) #2
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-07 14:08:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863213004/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863213004/20001
4 years, 8 months ago (2016-04-07 14:14:08 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: ios_dbg_simulator_ninja on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator_ninja/builds/155948)
4 years, 8 months ago (2016-04-07 14:27:55 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1863213004/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1863213004/40001
4 years, 8 months ago (2016-04-07 14:47:39 UTC) #10
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-07 15:42:24 UTC) #11
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 15:43:45 UTC) #13
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/4f3a2f39c45a4af0f05fd3ffde6c040db01a74e9
Cr-Commit-Position: refs/heads/master@{#385766}

Powered by Google App Engine
This is Rietveld 408576698