Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Issue 1864163006: [NTP Snippets] SnippetsController cleanup: remove SigninStateObserver (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org, May
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] SnippetsController cleanup: remove SigninStateObserver The logic for fetching snippets now lives on the C++ side. BUG=601034 Committed: https://crrev.com/a42da0526ecd8890becdb10f334e41a0365d9d37 Cr-Commit-Position: refs/heads/master@{#385709}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -27 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ChromeBackgroundService.java View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/ntp/snippets/SnippetsController.java View 2 chunks +4 lines, -22 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/ChromeBackgroundServiceTest.java View 1 chunk +0 lines, -4 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Marc Treib
PTAL!
4 years, 8 months ago (2016-04-07 10:11:58 UTC) #2
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-07 10:24:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1864163006/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1864163006/1
4 years, 8 months ago (2016-04-07 10:27:03 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 8 months ago (2016-04-07 10:59:46 UTC) #8
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 11:00:47 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a42da0526ecd8890becdb10f334e41a0365d9d37
Cr-Commit-Position: refs/heads/master@{#385709}

Powered by Google App Engine
This is Rietveld 408576698