Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(84)

Issue 1869023002: [NTP Snippets] SnippetsBridge: register as SnippetsObserver only when we get a Java observer (Closed)

Created:
4 years, 8 months ago by Marc Treib
Modified:
4 years, 8 months ago
Reviewers:
Bernhard Bauer
CC:
chromium-reviews, mcwilliams+watch_chromium.org, dgn+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@snippets_service_cleanup
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[NTP Snippets] SnippetsBridge: register as SnippetsObserver only when we get a Java observer since before, there's no point. While we're here, also remove the NTPSnippetsService* params from the observer methods, since nobody uses them. BUG=none Committed: https://crrev.com/d26b1bf2a6701bf576c909afd0075c450aeca392 Cr-Commit-Position: refs/heads/master@{#385798}

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -20 lines) Patch
M chrome/browser/android/ntp/ntp_snippets_bridge.h View 1 chunk +2 lines, -4 lines 0 comments Download
M chrome/browser/android/ntp/ntp_snippets_bridge.cc View 4 chunks +6 lines, -10 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/ntp_snippets/ntp_snippets_service.cc View 4 chunks +4 lines, -4 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 9 (4 generated)
Marc Treib
One more :) PTAL!
4 years, 8 months ago (2016-04-07 14:24:57 UTC) #2
Bernhard Bauer
lgtm
4 years, 8 months ago (2016-04-07 14:49:28 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1869023002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1869023002/20001
4 years, 8 months ago (2016-04-07 15:53:02 UTC) #6
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-07 17:52:09 UTC) #7
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 17:54:20 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d26b1bf2a6701bf576c909afd0075c450aeca392
Cr-Commit-Position: refs/heads/master@{#385798}

Powered by Google App Engine
This is Rietveld 408576698