Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Side by Side Diff: chrome/browser/android/ntp/ntp_snippets_bridge.cc

Issue 1863213004: [NTP Snippets] Cleanup: remove NTPSnippetsService::is_loaded() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: remove now-pointless tests Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_service.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h" 5 #include "chrome/browser/android/ntp/ntp_snippets_bridge.h"
6 6
7 #include <jni.h> 7 #include <jni.h>
8 8
9 #include "base/android/jni_android.h" 9 #include "base/android/jni_android.h"
10 #include "base/android/jni_array.h" 10 #include "base/android/jni_array.h"
(...skipping 25 matching lines...) Expand all
36 : snippet_service_observer_(this) { 36 : snippet_service_observer_(this) {
37 Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile); 37 Profile* profile = ProfileAndroid::FromProfileAndroid(j_profile);
38 ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile); 38 ntp_snippets_service_ = NTPSnippetsServiceFactory::GetForProfile(profile);
39 snippet_service_observer_.Add(ntp_snippets_service_); 39 snippet_service_observer_.Add(ntp_snippets_service_);
40 } 40 }
41 41
42 void NTPSnippetsBridge::SetObserver(JNIEnv* env, 42 void NTPSnippetsBridge::SetObserver(JNIEnv* env,
43 const JavaParamRef<jobject>& obj, 43 const JavaParamRef<jobject>& obj,
44 const JavaParamRef<jobject>& j_observer) { 44 const JavaParamRef<jobject>& j_observer) {
45 observer_.Reset(env, j_observer); 45 observer_.Reset(env, j_observer);
46 46 NTPSnippetsServiceLoaded(ntp_snippets_service_);
47 if (ntp_snippets_service_->is_loaded())
48 NTPSnippetsServiceLoaded(ntp_snippets_service_);
49 } 47 }
50 48
51 NTPSnippetsBridge::~NTPSnippetsBridge() {} 49 NTPSnippetsBridge::~NTPSnippetsBridge() {}
52 50
53 void NTPSnippetsBridge::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) { 51 void NTPSnippetsBridge::Destroy(JNIEnv* env, const JavaParamRef<jobject>& obj) {
54 delete this; 52 delete this;
55 } 53 }
56 54
57 void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env, 55 void NTPSnippetsBridge::DiscardSnippet(JNIEnv* env,
58 const JavaParamRef<jobject>& obj, 56 const JavaParamRef<jobject>& obj,
(...skipping 31 matching lines...) Expand 10 before | Expand all | Expand 10 after
90 void NTPSnippetsBridge::NTPSnippetsServiceShutdown( 88 void NTPSnippetsBridge::NTPSnippetsServiceShutdown(
91 NTPSnippetsService* service) { 89 NTPSnippetsService* service) {
92 observer_.Reset(); 90 observer_.Reset();
93 snippet_service_observer_.Remove(ntp_snippets_service_); 91 snippet_service_observer_.Remove(ntp_snippets_service_);
94 } 92 }
95 93
96 // static 94 // static
97 bool NTPSnippetsBridge::Register(JNIEnv* env) { 95 bool NTPSnippetsBridge::Register(JNIEnv* env) {
98 return RegisterNativesImpl(env); 96 return RegisterNativesImpl(env);
99 } 97 }
OLDNEW
« no previous file with comments | « no previous file | components/ntp_snippets/ntp_snippets_service.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698