Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1861963008: Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId (Closed)

Created:
4 years, 8 months ago by servolk
Modified:
4 years, 6 months ago
Reviewers:
chcunningham, wolenetz
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId Committed: https://crrev.com/a233f8353f7f29d4912c741a7366c0063633d91c Cr-Commit-Position: refs/heads/master@{#399263}

Patch Set 1 #

Patch Set 2 : rebase #

Total comments: 2

Patch Set 3 : Rename MediaTrack::id into byteStreamTrackId #

Patch Set 4 : Rebase + rename id to byteStreamTrackId #

Patch Set 5 : Use bytestream_track_id instead of camelCase #

Patch Set 6 : Don't include media_log.h into stream_parser.h to avoid circular includes #

Patch Set 7 : Include <algorithm> into stream_parser_buffer.cc #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -58 lines) Patch
M media/base/media_track.h View 1 2 3 4 3 chunks +6 lines, -3 lines 0 comments Download
M media/base/media_track.cc View 1 2 3 4 1 chunk +6 lines, -2 lines 0 comments Download
M media/base/media_tracks.h View 1 2 3 4 2 chunks +12 lines, -8 lines 0 comments Download
M media/base/media_tracks.cc View 1 2 3 4 4 chunks +16 lines, -16 lines 0 comments Download
M media/base/stream_parser.h View 1 2 3 4 5 1 chunk +1 line, -1 line 0 comments Download
M media/base/stream_parser_buffer.cc View 1 2 3 4 5 6 1 chunk +2 lines, -0 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 1 2 3 4 3 chunks +5 lines, -2 lines 0 comments Download
M media/blink/websourcebuffer_impl.cc View 1 2 3 4 2 chunks +3 lines, -1 line 0 comments Download
M media/filters/ffmpeg_demuxer.cc View 1 2 2 chunks +3 lines, -2 lines 0 comments Download
M media/filters/ffmpeg_demuxer_unittest.cc View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M media/filters/media_source_state.h View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/filters/media_source_state.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M media/formats/common/stream_parser_test_base.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser.cc View 1 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/mp2t/mp2t_stream_parser_unittest.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser.cc View 1 2 chunks +6 lines, -6 lines 0 comments Download
M media/formats/mp4/mp4_stream_parser_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/mpeg/adts_stream_parser.cc View 1 2 3 4 5 1 chunk +1 line, -0 lines 0 comments Download
M media/formats/mpeg/mpeg1_audio_stream_parser.cc View 1 2 3 4 5 1 chunk +2 lines, -0 lines 0 comments Download
M media/formats/mpeg/mpeg_audio_stream_parser_base.cc View 1 2 3 4 5 2 chunks +2 lines, -1 line 0 comments Download
M media/formats/webm/webm_stream_parser_unittest.cc View 1 2 3 4 1 chunk +2 lines, -2 lines 0 comments Download
M media/formats/webm/webm_tracks_parser.cc View 2 chunks +8 lines, -6 lines 0 comments Download

Dependent Patchsets:

Issue 2050043002 Patch 60001

Messages

Total messages: 19 (6 generated)
servolk
4 years, 8 months ago (2016-04-26 00:59:11 UTC) #3
chcunningham
https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc File media/base/media_track.cc (right): https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc#newcode10 media/base/media_track.cc:10: StreamParser::TrackId id, reminder: rename to byteStreamTrackId
4 years, 6 months ago (2016-06-03 18:23:15 UTC) #5
wolenetz
Per recommendation from servolk@, further CR of this is pending his (in progress) reworking and ...
4 years, 6 months ago (2016-06-07 20:39:03 UTC) #6
servolk
On 2016/06/07 20:39:03, wolenetz_slow_reviews wrote: > Per recommendation from servolk@, further CR of this is ...
4 years, 6 months ago (2016-06-09 00:12:36 UTC) #8
servolk
https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc File media/base/media_track.cc (right): https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc#newcode10 media/base/media_track.cc:10: StreamParser::TrackId id, On 2016/06/03 18:23:15, chcunningham wrote: > reminder: ...
4 years, 6 months ago (2016-06-09 00:12:42 UTC) #9
servolk
https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc File media/base/media_track.cc (right): https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc#newcode10 media/base/media_track.cc:10: StreamParser::TrackId id, On 2016/06/03 18:23:15, chcunningham wrote: > reminder: ...
4 years, 6 months ago (2016-06-09 00:12:42 UTC) #10
servolk
On 2016/06/09 00:12:42, servolk wrote: > https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc > File media/base/media_track.cc (right): > > https://codereview.chromium.org/1861963008/diff/20001/media/base/media_track.cc#newcode10 > ...
4 years, 6 months ago (2016-06-10 18:06:21 UTC) #11
chcunningham
lgtm
4 years, 6 months ago (2016-06-10 19:38:42 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861963008/120001
4 years, 6 months ago (2016-06-10 20:33:29 UTC) #14
commit-bot: I haz the power
Committed patchset #7 (id:120001)
4 years, 6 months ago (2016-06-10 20:39:16 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 20:39:22 UTC) #16
commit-bot: I haz the power
Patchset 7 (id:??) landed as https://crrev.com/a233f8353f7f29d4912c741a7366c0063633d91c Cr-Commit-Position: refs/heads/master@{#399263}
4 years, 6 months ago (2016-06-10 20:40:54 UTC) #18
wolenetz
4 years, 6 months ago (2016-06-10 20:58:00 UTC) #19
Message was sent while issue was closed. 
belated lgtm. There seems to all kinds of strange in webm_tracks_parser and int
vs uint parsing, but this change doesn't regress that.

Powered by Google App Engine
This is Rietveld 408576698