Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(489)

Side by Side Diff: media/filters/ffmpeg_demuxer_unittest.cc

Issue 1861963008: Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include <algorithm> into stream_parser_buffer.cc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | media/filters/media_source_state.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include <stddef.h> 5 #include <stddef.h>
6 #include <stdint.h> 6 #include <stdint.h>
7 7
8 #include <algorithm> 8 #include <algorithm>
9 #include <deque> 9 #include <deque>
10 #include <string> 10 #include <string>
(...skipping 1187 matching lines...) Expand 10 before | Expand all | Expand 10 after
1198 } 1198 }
1199 1199
1200 TEST_F(FFmpegDemuxerTest, Read_Mp4_Media_Track_Info) { 1200 TEST_F(FFmpegDemuxerTest, Read_Mp4_Media_Track_Info) {
1201 CreateDemuxer("bear.mp4"); 1201 CreateDemuxer("bear.mp4");
1202 InitializeDemuxer(); 1202 InitializeDemuxer();
1203 1203
1204 EXPECT_EQ(media_tracks_->tracks().size(), 2u); 1204 EXPECT_EQ(media_tracks_->tracks().size(), 2u);
1205 1205
1206 const MediaTrack& audio_track = *(media_tracks_->tracks()[0]); 1206 const MediaTrack& audio_track = *(media_tracks_->tracks()[0]);
1207 EXPECT_EQ(audio_track.type(), MediaTrack::Audio); 1207 EXPECT_EQ(audio_track.type(), MediaTrack::Audio);
1208 EXPECT_EQ(audio_track.id(), "1"); 1208 EXPECT_EQ(audio_track.bytestream_track_id(), 1);
1209 EXPECT_EQ(audio_track.kind(), "main"); 1209 EXPECT_EQ(audio_track.kind(), "main");
1210 EXPECT_EQ(audio_track.label(), "GPAC ISO Audio Handler"); 1210 EXPECT_EQ(audio_track.label(), "GPAC ISO Audio Handler");
1211 EXPECT_EQ(audio_track.language(), "und"); 1211 EXPECT_EQ(audio_track.language(), "und");
1212 1212
1213 const MediaTrack& video_track = *(media_tracks_->tracks()[1]); 1213 const MediaTrack& video_track = *(media_tracks_->tracks()[1]);
1214 EXPECT_EQ(video_track.type(), MediaTrack::Video); 1214 EXPECT_EQ(video_track.type(), MediaTrack::Video);
1215 EXPECT_EQ(video_track.id(), "2"); 1215 EXPECT_EQ(video_track.bytestream_track_id(), 2);
1216 EXPECT_EQ(video_track.kind(), "main"); 1216 EXPECT_EQ(video_track.kind(), "main");
1217 EXPECT_EQ(video_track.label(), "GPAC ISO Video Handler"); 1217 EXPECT_EQ(video_track.label(), "GPAC ISO Video Handler");
1218 EXPECT_EQ(video_track.language(), "und"); 1218 EXPECT_EQ(video_track.language(), "und");
1219 } 1219 }
1220 1220
1221 #endif // defined(USE_PROPRIETARY_CODECS) 1221 #endif // defined(USE_PROPRIETARY_CODECS)
1222 1222
1223 TEST_F(FFmpegDemuxerTest, Read_Webm_Media_Track_Info) { 1223 TEST_F(FFmpegDemuxerTest, Read_Webm_Media_Track_Info) {
1224 CreateDemuxer("bear.webm"); 1224 CreateDemuxer("bear.webm");
1225 InitializeDemuxer(); 1225 InitializeDemuxer();
1226 1226
1227 EXPECT_EQ(media_tracks_->tracks().size(), 2u); 1227 EXPECT_EQ(media_tracks_->tracks().size(), 2u);
1228 1228
1229 const MediaTrack& video_track = *(media_tracks_->tracks()[0]); 1229 const MediaTrack& video_track = *(media_tracks_->tracks()[0]);
1230 EXPECT_EQ(video_track.type(), MediaTrack::Video); 1230 EXPECT_EQ(video_track.type(), MediaTrack::Video);
1231 EXPECT_EQ(video_track.id(), "1"); 1231 EXPECT_EQ(video_track.bytestream_track_id(), 1);
1232 EXPECT_EQ(video_track.kind(), "main"); 1232 EXPECT_EQ(video_track.kind(), "main");
1233 EXPECT_EQ(video_track.label(), ""); 1233 EXPECT_EQ(video_track.label(), "");
1234 EXPECT_EQ(video_track.language(), ""); 1234 EXPECT_EQ(video_track.language(), "");
1235 1235
1236 const MediaTrack& audio_track = *(media_tracks_->tracks()[1]); 1236 const MediaTrack& audio_track = *(media_tracks_->tracks()[1]);
1237 EXPECT_EQ(audio_track.type(), MediaTrack::Audio); 1237 EXPECT_EQ(audio_track.type(), MediaTrack::Audio);
1238 EXPECT_EQ(audio_track.id(), "2"); 1238 EXPECT_EQ(audio_track.bytestream_track_id(), 2);
1239 EXPECT_EQ(audio_track.kind(), "main"); 1239 EXPECT_EQ(audio_track.kind(), "main");
1240 EXPECT_EQ(audio_track.label(), ""); 1240 EXPECT_EQ(audio_track.label(), "");
1241 EXPECT_EQ(audio_track.language(), ""); 1241 EXPECT_EQ(audio_track.language(), "");
1242 } 1242 }
1243 1243
1244 } // namespace media 1244 } // namespace media
OLDNEW
« no previous file with comments | « media/filters/ffmpeg_demuxer.cc ('k') | media/filters/media_source_state.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698