media/formats/mp4/mp4_stream_parser_unittest.cc - Issue 1861963008: Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: media/formats/mp4/mp4_stream_parser_unittest.cc

Issue 1861963008: Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Include <algorithm> into stream_parser_buffer.cc Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: media/formats/mp4/mp4_stream_parser_unittest.cc

diff --git a/media/formats/mp4/mp4_stream_parser_unittest.cc b/media/formats/mp4/mp4_stream_parser_unittest.cc

index e84a85b70c14b88b3ce2a6c8a31ca4d7ccee2621..7109c20ddf6ac118f815d2c4b08634574448b46b 100644

--- a/media/formats/mp4/mp4_stream_parser_unittest.cc

+++ b/media/formats/mp4/mp4_stream_parser_unittest.cc

@@ -499,14 +499,14 @@ TEST_F(MP4StreamParserTest, MediaTrackInfoSourcing) {

EXPECT_EQ(media_tracks_->tracks().size(), 2u);

const MediaTrack& video_track = *(media_tracks_->tracks()[0]);

EXPECT_EQ(video_track.type(), MediaTrack::Video);

- EXPECT_EQ(video_track.id(), "1");

+ EXPECT_EQ(video_track.bytestream_track_id(), 1);

EXPECT_EQ(video_track.kind(), "main");

EXPECT_EQ(video_track.label(), "VideoHandler");

EXPECT_EQ(video_track.language(), "und");

const MediaTrack& audio_track = *(media_tracks_->tracks()[1]);

EXPECT_EQ(audio_track.type(), MediaTrack::Audio);

- EXPECT_EQ(audio_track.id(), "2");

+ EXPECT_EQ(audio_track.bytestream_track_id(), 2);

EXPECT_EQ(audio_track.kind(), "main");

EXPECT_EQ(audio_track.label(), "SoundHandler");

EXPECT_EQ(audio_track.language(), "und");

« no previous file with comments | « media/formats/mp4/mp4_stream_parser.cc ('k') | media/formats/mpeg/adts_stream_parser.cc » ('j') | no next file with comments »