Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Side by Side Diff: media/base/media_tracks.cc

Issue 1861963008: Use StreamParser::TrackId instead of string for MediaTrack::byteStreamTrackId (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Include <algorithm> into stream_parser_buffer.cc Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « media/base/media_tracks.h ('k') | media/base/stream_parser.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "media/base/media_tracks.h" 5 #include "media/base/media_tracks.h"
6 6
7 #include "base/bind.h" 7 #include "base/bind.h"
8 #include "base/memory/ptr_util.h" 8 #include "base/memory/ptr_util.h"
9 #include "media/base/audio_decoder_config.h" 9 #include "media/base/audio_decoder_config.h"
10 #include "media/base/video_decoder_config.h" 10 #include "media/base/video_decoder_config.h"
11 11
12 namespace media { 12 namespace media {
13 13
14 MediaTracks::MediaTracks() {} 14 MediaTracks::MediaTracks() {}
15 15
16 MediaTracks::~MediaTracks() {} 16 MediaTracks::~MediaTracks() {}
17 17
18 void MediaTracks::AddAudioTrack(const AudioDecoderConfig& config, 18 void MediaTracks::AddAudioTrack(const AudioDecoderConfig& config,
19 const std::string& id, 19 StreamParser::TrackId bytestream_track_id,
20 const std::string& kind, 20 const std::string& kind,
21 const std::string& label, 21 const std::string& label,
22 const std::string& language) { 22 const std::string& language) {
23 DCHECK(config.IsValidConfig()); 23 DCHECK(config.IsValidConfig());
24 CHECK(audio_configs_.find(id) == audio_configs_.end()); 24 CHECK(audio_configs_.find(bytestream_track_id) == audio_configs_.end());
25 std::unique_ptr<MediaTrack> track = base::WrapUnique( 25 std::unique_ptr<MediaTrack> track = base::WrapUnique(new MediaTrack(
26 new MediaTrack(MediaTrack::Audio, id, kind, label, language)); 26 MediaTrack::Audio, bytestream_track_id, kind, label, language));
27 tracks_.push_back(std::move(track)); 27 tracks_.push_back(std::move(track));
28 audio_configs_[id] = config; 28 audio_configs_[bytestream_track_id] = config;
29 } 29 }
30 30
31 void MediaTracks::AddVideoTrack(const VideoDecoderConfig& config, 31 void MediaTracks::AddVideoTrack(const VideoDecoderConfig& config,
32 const std::string& id, 32 StreamParser::TrackId bytestream_track_id,
33 const std::string& kind, 33 const std::string& kind,
34 const std::string& label, 34 const std::string& label,
35 const std::string& language) { 35 const std::string& language) {
36 DCHECK(config.IsValidConfig()); 36 DCHECK(config.IsValidConfig());
37 CHECK(video_configs_.find(id) == video_configs_.end()); 37 CHECK(video_configs_.find(bytestream_track_id) == video_configs_.end());
38 std::unique_ptr<MediaTrack> track = base::WrapUnique( 38 std::unique_ptr<MediaTrack> track = base::WrapUnique(new MediaTrack(
39 new MediaTrack(MediaTrack::Video, id, kind, label, language)); 39 MediaTrack::Video, bytestream_track_id, kind, label, language));
40 tracks_.push_back(std::move(track)); 40 tracks_.push_back(std::move(track));
41 video_configs_[id] = config; 41 video_configs_[bytestream_track_id] = config;
42 } 42 }
43 43
44 const AudioDecoderConfig& MediaTracks::getAudioConfig( 44 const AudioDecoderConfig& MediaTracks::getAudioConfig(
45 const std::string& id) const { 45 StreamParser::TrackId bytestream_track_id) const {
46 auto it = audio_configs_.find(id); 46 auto it = audio_configs_.find(bytestream_track_id);
47 if (it != audio_configs_.end()) 47 if (it != audio_configs_.end())
48 return it->second; 48 return it->second;
49 static AudioDecoderConfig invalidConfig; 49 static AudioDecoderConfig invalidConfig;
50 return invalidConfig; 50 return invalidConfig;
51 } 51 }
52 52
53 const VideoDecoderConfig& MediaTracks::getVideoConfig( 53 const VideoDecoderConfig& MediaTracks::getVideoConfig(
54 const std::string& id) const { 54 StreamParser::TrackId bytestream_track_id) const {
55 auto it = video_configs_.find(id); 55 auto it = video_configs_.find(bytestream_track_id);
56 if (it != video_configs_.end()) 56 if (it != video_configs_.end())
57 return it->second; 57 return it->second;
58 static VideoDecoderConfig invalidConfig; 58 static VideoDecoderConfig invalidConfig;
59 return invalidConfig; 59 return invalidConfig;
60 } 60 }
61 61
62 const AudioDecoderConfig& MediaTracks::getFirstAudioConfig() const { 62 const AudioDecoderConfig& MediaTracks::getFirstAudioConfig() const {
63 for (const auto& track : tracks()) { 63 for (const auto& track : tracks()) {
64 if (track->type() == MediaTrack::Audio) { 64 if (track->type() == MediaTrack::Audio) {
65 return getAudioConfig(track->id()); 65 return getAudioConfig(track->bytestream_track_id());
66 } 66 }
67 } 67 }
68 static AudioDecoderConfig invalidConfig; 68 static AudioDecoderConfig invalidConfig;
69 return invalidConfig; 69 return invalidConfig;
70 } 70 }
71 71
72 const VideoDecoderConfig& MediaTracks::getFirstVideoConfig() const { 72 const VideoDecoderConfig& MediaTracks::getFirstVideoConfig() const {
73 for (const auto& track : tracks()) { 73 for (const auto& track : tracks()) {
74 if (track->type() == MediaTrack::Video) { 74 if (track->type() == MediaTrack::Video) {
75 return getVideoConfig(track->id()); 75 return getVideoConfig(track->bytestream_track_id());
76 } 76 }
77 } 77 }
78 static VideoDecoderConfig invalidConfig; 78 static VideoDecoderConfig invalidConfig;
79 return invalidConfig; 79 return invalidConfig;
80 } 80 }
81 81
82 } // namespace media 82 } // namespace media
OLDNEW
« no previous file with comments | « media/base/media_tracks.h ('k') | media/base/stream_parser.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698