Convert //ios from scoped_ptr to std::unique_ptr.

Convert //ios from scoped_ptr to std::unique_ptr.

BUG=554298
R=rohitrao@chromium.org

Committed: https://crrev.com/942f39d75745824a53ef6ce896bb2462010476bb
Cr-Commit-Position: refs/heads/master@{#385849}

[dcheng, 2016-04-06 22:36:41]

As one of the larger CLs, I did some spot checks that the results look
reasonable. Hopefully the bots are happy too.

[vabr (Chromium), 2016-04-06 22:46:32]

vabr@chromium.org changed reviewers:
+ vabr@chromium.org

[vabr (Chromium), 2016-04-06 22:46:35]

ios/chrome/browser/passwords/* LGTM with an optional comment.

Thanks for this improvement!

Vaclav

https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc (right):

https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc:7: #include
<utility>
optional:
#include <memory> because of line 76.

[dcheng, 2016-04-07 00:29:24]

https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc (right):

https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc:7: #include
<utility>
On 2016/04/06 at 22:46:35, vabr (Chromium) wrote:
> optional:
> #include <memory> because of line 76.

Done.

[vabr (Chromium), 2016-04-07 02:05:30]

On 2016/04/07 00:29:24, dcheng wrote:
>
https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
> File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc
(right):
> 
>
https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/password...
> ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc:7: #include
> <utility>
> On 2016/04/06 at 22:46:35, vabr (Chromium) wrote:
> > optional:
> > #include <memory> because of line 76.
> 
> Done.

Thanks, LGTM.

[noyau (Ping after 24h), 2016-04-07 13:33:59]

noyau@chromium.org changed reviewers:
+ noyau@chromium.org

[noyau (Ping after 24h), 2016-04-07 13:34:06]

Oh, my, that's a big CL. Thanks for doing this.

I did a pass at the header files, making sure they were self contained, and I
found a number of issues (that predate your changes, of course, but this CL
makes it very apparent). I expect that when those are fixed some implementation
files will stop to compile as they won't include memory transitively anymore.

Ideally the same pass needs to be done on .mm and .cc files.

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/brow...
File
ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/brow...
ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.h:7:

#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/brow...
File ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/brow...
ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h:8: #include
<set>
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/info...
File ios/chrome/browser/infobars/infobar.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/info...
ios/chrome/browser/infobars/infobar.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/inva...
File
ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/inva...
ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.h:7:

#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/net/...
File ios/chrome/browser/net/cookie_util.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/net/...
ios/chrome/browser/net/cookie_util.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/pass...
File
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.h:7:

#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/pass...
File ios/chrome/browser/passwords/password_controller.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/pass...
ios/chrome/browser/passwords/password_controller.h:8: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/read...
File ios/chrome/browser/reading_list/reading_list_model_factory.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/read...
ios/chrome/browser/reading_list/reading_list_model_factory.h:8: #include
"components/keyed_service/ios/browser_state_keyed_service_factory.h"
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/safe...
File ios/chrome/browser/safe_browsing/protocol_manager_helper.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/safe...
ios/chrome/browser/safe_browsing/protocol_manager_helper.h:11: #include <memory>
I don't see unique_ptr in this file, this include is probably not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/safe...
File ios/chrome/browser/safe_browsing/safe_browsing_blocking_page.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/safe...
ios/chrome/browser/safe_browsing/safe_browsing_blocking_page.h:34: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sess...
File ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sess...
ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/shar...
File ios/chrome/browser/share_extension/share_extension_service.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/shar...
ios/chrome/browser/share_extension/share_extension_service.h:8: #include
<memory>
Apparently not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/shar...
File ios/chrome/browser/share_extension/share_extension_service_factory.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/shar...
ios/chrome/browser/share_extension/share_extension_service_factory.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/ios_chrome_sync_client.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/ios_chrome_sync_client.h:8: #include <vector>
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
File ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/sync...
ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.h:8:
#include <stddef.h>
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/tran...
File ios/chrome/browser/translate/translate_accept_languages_factory.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/tran...
ios/chrome/browser/translate/translate_accept_languages_factory.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/ui/w...
File ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h
(right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h:8:
#include <string>
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/ui/w...
File ios/chrome/browser/ui/webui/version_handler.cc (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/chrome/browser/ui/w...
ios/chrome/browser/ui/webui/version_handler.cc:7: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/crnet/crnet_environ...
File ios/crnet/crnet_environment.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/crnet/crnet_environ...
ios/crnet/crnet_environment.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/crnet/sdch_owner_pr...
File ios/crnet/sdch_owner_pref_storage.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/crnet/sdch_owner_pr...
ios/crnet/sdch_owner_pref_storage.h:7: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/net/clients/crn_net...
File ios/net/clients/crn_network_client_protocol.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/net/clients/crn_net...
ios/net/clients/crn_network_client_protocol.h:10: #include <memory>
Not needed apparently.

https://codereview.chromium.org/1861593005/diff/20001/ios/net/http_response_h...
File ios/net/http_response_headers_util.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/net/http_response_h...
ios/net/http_response_headers_util.h:8: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/active_state_ma...
File ios/web/active_state_manager_impl_unittest.mm (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/active_state_ma...
ios/web/active_state_manager_impl_unittest.mm:7: #include <memory>
Not needed I think.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/interstitials/n...
File ios/web/interstitials/native_web_interstitial_impl.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/interstitials/n...
ios/web/interstitials/native_web_interstitial_impl.h:9: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/web/navigation/crw_...
File ios/web/navigation/crw_session_controller_unittest.mm (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/navigation/crw_...
ios/web/navigation/crw_session_controller_unittest.mm:9: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/net/cert_verifi...
File ios/web/net/cert_verifier_block_adapter.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/net/cert_verifi...
ios/web/net/cert_verifier_block_adapter.h:8: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/public/test/tes...
File ios/web/public/test/test_web_client.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/public/test/tes...
ios/web/public/test/test_web_client.h:10: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/public/web_thre...
File ios/web/public/web_thread.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/public/web_thre...
ios/web/public/web_thread.h:260: // Sample usage with scoped_ptr:
s/scoped_ptr/std::unique_ptr/

https://codereview.chromium.org/1861593005/diff/20001/ios/web/shell/shell_bro...
File ios/web/shell/shell_browser_state.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/shell/shell_bro...
ios/web/shell/shell_browser_state.h:8: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/shell/shell_bro...
File ios/web/shell/shell_browser_state.mm (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/shell/shell_bro...
ios/web/shell/shell_browser_state.mm:7: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller+protected.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller+protected.h:11: 
#import <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_web_controller.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_web_controller.h:10: #include <memory>
Not needed.

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
File ios/web/web_state/ui/crw_wk_web_view_web_controller.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/web_state/ui/cr...
ios/web/web_state/ui/crw_wk_web_view_web_controller.h:9: 
#include <memory>

https://codereview.chromium.org/1861593005/diff/20001/ios/web/webui/crw_web_u...
File ios/web/webui/crw_web_ui_manager.h (right):

https://codereview.chromium.org/1861593005/diff/20001/ios/web/webui/crw_web_u...
ios/web/webui/crw_web_ui_manager.h:9: 
#include <memory>

[rohitrao (ping after 24h), 2016-04-07 15:18:20]

Do these IWYU fixes need to be part of this mechanical CL, or can we make a
separate pass later to clean these up?

The advantage of doing them later is that we can make smaller CLs and run
changes through the downstream trybots.

[noyau (Ping after 24h), 2016-04-07 18:44:50]

On 2016/04/07 15:18:20, rohitrao wrote:
> Do these IWYU fixes need to be part of this mechanical CL, or can we make a
> separate pass later to clean these up?
> 
> The advantage of doing them later is that we can make smaller CLs and run
> changes through the downstream trybots.

I'm not fussy. It can be done both ways, especially as those are issues that
predated the change. It's just that it is easier to spot the issues looking at
the diffs in this CL than starting from scratch.

[dcheng, 2016-04-07 18:48:33]

I've addressed the various comments. I'd prefer not to make any further IWYU
fixes in this CL; fixing these instances is an explicit non-goal, given that
there are still 60k+ references across Chromium.

[dcheng, 2016-04-07 18:51:47]

On 2016/04/07 at 18:44:50, noyau wrote:
> On 2016/04/07 15:18:20, rohitrao wrote:
> > Do these IWYU fixes need to be part of this mechanical CL, or can we make a
> > separate pass later to clean these up?
> > 
> > The advantage of doing them later is that we can make smaller CLs and run
> > changes through the downstream trybots.
> 
> I'm not fussy. It can be done both ways, especially as those are issues that
predated the change. It's just that it is easier to spot the issues looking at
the diffs in this CL than starting from scratch.

It's pretty straightforward to look at the diffs after the fact too and generate
fixes based on that. I'm not volunteering though.

[noyau (Ping after 24h), 2016-04-07 19:05:08]

lgtm

[noyau (Ping after 24h), 2016-04-07 19:09:02]

On 2016/04/07 18:51:47, dcheng wrote:
> > 
> > I'm not fussy. It can be done both ways, especially as those are issues that
> > predated the change. It's just that it is easier to spot the issues looking
at
> > the diffs in this CL than starting from scratch.
> It's pretty straightforward to look at the diffs after the fact too and
generate
> fixes based on that. I'm not volunteering though.

Understood. There are quite a lot of include errors like these anyway, and those
should probably be fixed with tooling rather than manually.

[dcheng, 2016-04-07 19:13:11]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 19:13:13]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org
Link to the patchset: https://codereview.chromium.org/1861593005/#ps60001
(title: "Address comments")

[commit-bot: I haz the power, 2016-04-07 19:14:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861593005/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861593005/60001

[commit-bot: I haz the power, 2016-04-07 19:19:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-07 19:19:12]

Try jobs failed on following builders:
  ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[dcheng, 2016-04-07 19:38:13]

The CQ bit was checked by dcheng@chromium.org

[dcheng, 2016-04-07 19:38:15]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
noyau@chromium.org
Link to the patchset: https://codereview.chromium.org/1861593005/#ps80001
(title: "rebase?")

[commit-bot: I haz the power, 2016-04-07 19:38:50]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1861593005/80001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1861593005/80001

[commit-bot: I haz the power, 2016-04-07 21:11:40]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-04-07 21:29:17]

Description was changed from

==========
Convert //ios from scoped_ptr to std::unique_ptr.

BUG=554298
R=rohitrao@chromium.org
==========

to

==========
Convert //ios from scoped_ptr to std::unique_ptr.

BUG=554298
R=rohitrao@chromium.org

Committed: https://crrev.com/942f39d75745824a53ef6ce896bb2462010476bb
Cr-Commit-Position: refs/heads/master@{#385849}
==========

[commit-bot: I haz the power, 2016-04-07 21:29:21]

Patchset 5 (id:??) landed as
https://crrev.com/942f39d75745824a53ef6ce896bb2462010476bb
Cr-Commit-Position: refs/heads/master@{#385849}