Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(954)

Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr. (Closed)

Created:
4 years, 8 months ago by dcheng
Modified:
4 years, 8 months ago
CC:
asvitkine+watch_chromium.org, bondd+autofillwatch_chromium.org, browser-components-watch_chromium.org, cbentzel+watch_chromium.org, chromium-apps-reviews_chromium.org, chromium-reviews, dbeam+watch-history_chromium.org, dgn+watch_chromium.org, Patrick Dubroy, estade+watch_chromium.org, extensions-reviews_chromium.org, gavinp+disk_chromium.org, gcasto+watchlist_chromium.org, grt+watch_chromium.org, jdonnelly+autofillwatch_chromium.org, johnme+watch_chromium.org, markusheintz_, mcwilliams+watch_chromium.org, mkwst+watchlist-passwords_chromium.org, mlamouri+watch-geolocation_chromium.org, Michael van Ouwerkerk, noyau+watch_chromium.org, pam+watch_chromium.org, Peter Beverloo, rouslan+autofill_chromium.org, sdefresne+watch_chromium.org, James Su, sync-reviews_chromium.org, tfarina, vabr+watchlistpasswordmanager_chromium.org, vabr+watchlistautofill_chromium.org, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert //ios from scoped_ptr to std::unique_ptr. BUG=554298 R=rohitrao@chromium.org Committed: https://crrev.com/942f39d75745824a53ef6ce896bb2462010476bb Cr-Commit-Position: refs/heads/master@{#385849}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add header #

Total comments: 35

Patch Set 3 : rebase #

Patch Set 4 : Address comments #

Patch Set 5 : rebase? #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1372 lines, -1098 lines) Patch
M ios/chrome/browser/application_context_impl.h View 1 2 3 4 2 chunks +9 lines, -9 lines 0 comments Download
M ios/chrome/browser/application_context_impl.cc View 1 2 3 4 4 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_classifier_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_classifier_factory.cc View 3 chunks +8 lines, -6 lines 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/autocomplete_provider_client_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/autocomplete/in_memory_url_index_factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/autocomplete/shortcuts_backend_factory.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/autofill/form_input_accessory_view_controller.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/autofill/form_suggestion_controller.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/autofill/personal_data_manager_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/autofill/personal_data_manager_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/bookmarks/bookmark_model_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/bookmarks/bookmark_model_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/bookmarks/startup_task_runner_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/bookmarks/startup_task_runner_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/browser_state_info_cache.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.h View 4 chunks +10 lines, -8 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.h View 3 chunks +11 lines, -10 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_impl_io_data.mm View 1 2 3 4 9 chunks +21 lines, -18 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.h View 1 2 3 4 13 chunks +34 lines, -31 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_io_data.cc View 1 2 3 4 11 chunks +27 lines, -25 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/browser_state/chrome_browser_state_manager_impl.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_impl.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.h View 4 chunks +12 lines, -10 lines 0 comments Download
M ios/chrome/browser/browser_state/off_the_record_chrome_browser_state_io_data.mm View 1 2 3 4 4 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.h View 5 chunks +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state.mm View 5 chunks +14 lines, -12 lines 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/browser_state/test_chrome_browser_state_isolated_context.mm View 1 chunk +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/browsing_data/browsing_data_remover_helper.h View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/browsing_data/browsing_data_remover_helper.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/browsing_data/ios_chrome_browsing_data_remover.h View 1 2 3 3 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/crash_report/crash_report_multi_parameter.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.h View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/dom_distiller/distiller_viewer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/dom_distiller/dom_distiller_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/dom_distiller/dom_distiller_service_factory.cc View 3 chunks +17 lines, -13 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_loader.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_loader.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/favicon_service_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.mm View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_cache_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/ios_chrome_large_icon_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/favicon/large_icon_cache.h View 3 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/favicon/large_icon_cache.cc View 3 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/favicon/large_icon_cache_unittest.cc View 4 chunks +9 lines, -8 lines 0 comments Download
M ios/chrome/browser/find_in_page/find_in_page_controller.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/find_in_page/js_findinpage_manager.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/geolocation/omnibox_geolocation_local_state_unittest.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/google/google_url_tracker_factory.cc View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/history/history_client_impl.h View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/history/history_client_impl.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/history/history_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/history/history_service_factory.cc View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/history/web_history_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/history/web_history_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/infobars/infobar.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar_controller.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/infobars/infobar_manager_impl.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_manager_impl.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_utils.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/infobars/infobar_utils.mm View 1 chunk +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/installation_notifier.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/installation_notifier_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/interstitials/ios_security_interstitial_page.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/invalidation/ios_chrome_profile_invalidation_provider_factory.mm View 2 chunks +13 lines, -11 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.h View 4 chunks +26 lines, -24 lines 0 comments Download
M ios/chrome/browser/ios_chrome_io_thread.mm View 6 chunks +8 lines, -6 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/ios_chrome_main_parts.mm View 4 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/memory/memory_debugger.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/memory/memory_metrics.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.h View 5 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_service_client.cc View 5 chunks +20 lines, -17 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.h View 3 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_metrics_services_manager_client.mm View 1 2 3 4 4 chunks +8 lines, -7 lines 0 comments Download
M ios/chrome/browser/metrics/ios_chrome_stability_metrics_provider_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/metrics/mobile_session_shutdown_metrics_provider_unittest.mm View 2 chunks +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/net/cookie_util.h View 1 2 3 2 chunks +4 lines, -1 line 0 comments Download
M ios/chrome/browser/net/cookie_util.mm View 5 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/net/image_fetcher.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/image_fetcher_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_network_delegate.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/net/ios_chrome_url_request_context_getter.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/net/ios_chrome_url_request_context_getter.cc View 4 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/net/proxy_service_factory.h View 2 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/net/proxy_service_factory.cc View 3 chunks +10 lines, -9 lines 0 comments Download
M ios/chrome/browser/net/retryable_url_fetcher.mm View 2 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/net/retryable_url_fetcher_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ntp_snippets/ios_chrome_ntp_snippets_service_factory.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/open_from_clipboard/create_clipboard_recent_content.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/passwords/credential_manager.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_client.h View 3 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_client.mm View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_manager_setting_migrator_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc View 1 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.h View 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/passwords/ios_chrome_save_password_infobar_delegate.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/passwords/password_controller.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/passwords/password_controller.mm View 9 chunks +19 lines, -16 lines 0 comments Download
M ios/chrome/browser/passwords/password_controller_unittest.mm View 3 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/passwords/password_generation_agent.mm View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.h View 2 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/prefs/ios_chrome_pref_service_factory.cc View 6 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_memory.h View 1 chunk +2 lines, -1 line 0 comments Download
M ios/chrome/browser/reading_list/reading_list_model_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/rlz/rlz_tracker_delegate_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/search_engines/template_url_service_factory.cc View 3 chunks +8 lines, -5 lines 0 comments Download
M ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/services/gcm/ios_chrome_gcm_profile_service_factory.cc View 3 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/sessions/ios_chrome_tab_restore_service_factory.cc View 3 chunks +6 lines, -4 lines 0 comments Download
M ios/chrome/browser/share_extension/share_extension_service.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/share_extension/share_extension_service_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/share_extension/share_extension_service_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/about_signin_internals_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/about_signin_internals_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_consistency_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_consistency_service_factory.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_fetcher_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_fetcher_service_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_reconcilor_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_reconcilor_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_tracker_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/account_tracker_service_factory.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/chrome_identity_service_observer_bridge_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/fake_oauth2_token_service_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/fake_oauth2_token_service_builder.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/fake_signin_manager_builder.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/fake_signin_manager_builder.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/gaia_auth_fetcher_ios.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/gaia_auth_fetcher_ios_unittest.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/signin/gaia_cookie_manager_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/gaia_cookie_manager_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/oauth2_token_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/oauth2_token_service_factory.mm View 3 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_client_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_client_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_client_impl.h View 4 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/signin/signin_client_impl.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/signin/signin_error_controller_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_error_controller_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_manager_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/signin/signin_manager_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/snapshots/lru_cache.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ssl/ios_chrome_security_state_model_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.h View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ssl/ios_ssl_blocking_page.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/suggestions/image_fetcher_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/suggestions/suggestions_service_factory.mm View 3 chunks +9 lines, -7 lines 0 comments Download
M ios/chrome/browser/sync/fake_sync_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/sync/fake_sync_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_service_factory.cc View 4 chunks +5 lines, -4 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_profile_sync_test_util.cc View 3 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.h View 1 2 3 3 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/sync/ios_chrome_sync_client.mm View 3 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/sync/sessions/ios_chrome_local_session_event_router.h View 1 2 3 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/sync/sync_setup_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/tab_parenting_global_observer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/tab_parenting_global_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.h View 4 chunks +7 lines, -6 lines 0 comments Download
M ios/chrome/browser/translate/chrome_ios_translate_client.mm View 3 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/translate/translate_accept_languages_factory.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/chrome/browser/translate/translate_accept_languages_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.h View 4 chunks +4 lines, -4 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_client_ios.mm View 3 chunks +7 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/autofill/autofill_save_card_infobar.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/flags_ui.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/chrome/browser/ui/webui/history/browsing_history_handler.cc View 4 chunks +6 lines, -5 lines 0 comments Download
M ios/chrome/browser/ui/webui/net_export/net_export_ui.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h View 1 2 3 3 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M ios/chrome/browser/ui/webui/version_handler.cc View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/chrome/browser/undo/bookmark_undo_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/undo/bookmark_undo_service_factory.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/chrome/browser/updatable_config/updatable_config_base.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/browser/web_data_service_factory.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/web_data_service_factory.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/browser/web_resource/web_resource_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/web_resource/web_resource_util_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/chrome/test/ios_chrome_scoped_testing_chrome_browser_provider.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/test/ios_chrome_unit_test_suite.mm View 1 chunk +3 lines, -3 lines 0 comments Download
M ios/chrome/test/testing_application_context.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/test/testing_application_context.mm View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M ios/chrome/tools/strings/generate_localizable_strings.mm View 2 chunks +5 lines, -4 lines 0 comments Download
M ios/crnet/crnet_environment.h View 1 2 3 2 chunks +17 lines, -14 lines 0 comments Download
M ios/crnet/crnet_environment.mm View 4 chunks +7 lines, -8 lines 0 comments Download
M ios/crnet/sdch_owner_pref_storage.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/crnet/sdch_owner_pref_storage.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ios/net/clients/crn_network_client_protocol.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/net/cookies/cookie_store_ios.h View 6 chunks +6 lines, -6 lines 0 comments Download
M ios/net/cookies/cookie_store_ios.mm View 4 chunks +5 lines, -6 lines 0 comments Download
M ios/net/cookies/cookie_store_ios_unittest.mm View 20 chunks +32 lines, -30 lines 0 comments Download
M ios/net/crn_http_protocol_handler.mm View 6 chunks +6 lines, -5 lines 0 comments Download
M ios/net/http_cache_helper.cc View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/net/http_response_headers_util.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/net/protocol_handler_util_unittest.mm View 9 chunks +12 lines, -11 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.h View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
M ios/public/provider/chrome/browser/chrome_browser_provider.mm View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_browser_provider.h View 2 chunks +6 lines, -4 lines 0 comments Download
M ios/public/provider/chrome/browser/test_chrome_provider_initializer.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/public/provider/web/web_controller_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/public/provider/web/web_controller_provider.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/active_state_manager_impl_unittest.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/app/web_main_loop.h View 2 chunks +14 lines, -13 lines 0 comments Download
M ios/web/app/web_main_loop.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/app/web_main_runner.mm View 1 chunk +2 lines, -2 lines 0 comments Download
M ios/web/browser_state_web_view_partition_inttest.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/web/interstitials/html_web_interstitial_impl.h View 3 chunks +8 lines, -6 lines 0 comments Download
M ios/web/interstitials/html_web_interstitial_impl.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.h View 1 2 3 3 chunks +8 lines, -5 lines 0 comments Download
M ios/web/interstitials/native_web_interstitial_impl.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_controller.mm View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_controller_unittest.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/navigation/crw_session_entry.h View 2 chunks +4 lines, -2 lines 0 comments Download
M ios/web/navigation/crw_session_entry.mm View 3 chunks +5 lines, -3 lines 0 comments Download
M ios/web/navigation/crw_session_entry_unittest.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/navigation/navigation_item_impl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_item_impl.mm View 3 chunks +4 lines, -4 lines 0 comments Download
M ios/web/navigation/navigation_item_impl_unittest.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.h View 3 chunks +3 lines, -3 lines 0 comments Download
M ios/web/navigation/navigation_manager_impl.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/navigation/navigation_manager_impl_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/cert_verifier_block_adapter.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/net/cert_verifier_block_adapter.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/net/cert_verifier_block_adapter_unittest.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/web/net/crw_cert_verification_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/crw_ssl_status_updater_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/net/request_tracker_impl_unittest.mm View 3 chunks +3 lines, -2 lines 0 comments Download
M ios/web/net/web_http_protocol_handler_delegate_unittest.mm View 2 chunks +5 lines, -3 lines 0 comments Download
M ios/web/public/app/web_main.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/public/interstitials/web_interstitial.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ios/web/public/navigation_item.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/public/test/http_server.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/test/http_server_inttest.mm View 2 chunks +4 lines, -4 lines 0 comments Download
M ios/web/public/test/response_providers/file_based_response_provider.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/public/test/scoped_testing_web_client.h View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/web/public/test/scoped_testing_web_client.mm View 1 chunk +2 lines, -1 line 0 comments Download
M ios/web/public/test/test_web_client.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/public/test/test_web_thread.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/public/test/test_web_thread_bundle.h View 2 chunks +9 lines, -8 lines 0 comments Download
M ios/web/public/web_controller_factory.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/public/web_controller_factory.mm View 1 chunk +3 lines, -2 lines 0 comments Download
M ios/web/public/web_thread.h View 1 2 3 2 chunks +5 lines, -5 lines 0 comments Download
M ios/web/shell/app_delegate.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/web/shell/shell_browser_state.h View 1 2 3 1 chunk +1 line, -3 lines 0 comments Download
M ios/web/shell/shell_browser_state.mm View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/shell/shell_main_delegate.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/shell/shell_url_request_context_getter.h View 2 chunks +9 lines, -7 lines 0 comments Download
M ios/web/shell/shell_url_request_context_getter.mm View 4 chunks +15 lines, -13 lines 0 comments Download
M ios/web/shell/shell_web_client.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/shell/shell_web_main_parts.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/shell/view_controller.mm View 3 chunks +4 lines, -3 lines 0 comments Download
M ios/web/test/web_test.mm View 1 2 3 chunks +4 lines, -2 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader.mm View 2 chunks +4 lines, -3 lines 0 comments Download
M ios/web/web_state/crw_pass_kit_downloader_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/web_state/js/credential_util_unittest.mm View 13 chunks +19 lines, -15 lines 0 comments Download
M ios/web/web_state/js/crw_js_early_script_manager_unittest.mm View 1 2 2 chunks +3 lines, -1 line 0 comments Download
M ios/web/web_state/js/crw_js_window_id_manager_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.h View 1 2 3 1 chunk +0 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller.mm View 1 2 15 chunks +52 lines, -45 lines 0 comments Download
M ios/web/web_state/ui/crw_web_controller+protected.h View 1 2 3 2 chunks +3 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_web_controller_unittest.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_script_message_router_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.h View 1 2 3 1 chunk +3 lines, -1 line 0 comments Download
M ios/web/web_state/ui/crw_wk_web_view_web_controller.mm View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/ui/wk_back_forward_list_item_holder_unittest.mm View 5 chunks +6 lines, -6 lines 0 comments Download
M ios/web/web_state/ui/wk_web_view_configuration_provider_unittest.mm View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/web_state/web_state_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/web_state/web_state_impl_unittest.mm View 5 chunks +7 lines, -5 lines 0 comments Download
M ios/web/web_state/web_view_internal_creation_util_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/web/web_state/wk_web_view_security_util_unittest.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager.h View 1 2 3 2 chunks +5 lines, -3 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager.mm View 2 chunks +5 lines, -5 lines 0 comments Download
M ios/web/webui/crw_web_ui_manager_unittest.mm View 5 chunks +14 lines, -12 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.h View 2 chunks +2 lines, -2 lines 0 comments Download
M ios/web/webui/url_data_manager_ios_backend.mm View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/webui/url_data_source_ios_impl.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/webui/url_fetcher_block_adapter.h View 2 chunks +3 lines, -2 lines 0 comments Download
M ios/web/webui/web_ui_ios_impl.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (8 generated)
dcheng
As one of the larger CLs, I did some spot checks that the results look ...
4 years, 8 months ago (2016-04-06 22:36:41 UTC) #1
vabr (Chromium)
ios/chrome/browser/passwords/* LGTM with an optional comment. Thanks for this improvement! Vaclav https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc (right): ...
4 years, 8 months ago (2016-04-06 22:46:35 UTC) #3
dcheng
https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc (right): https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc#newcode7 ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc:7: #include <utility> On 2016/04/06 at 22:46:35, vabr (Chromium) wrote: ...
4 years, 8 months ago (2016-04-07 00:29:24 UTC) #4
vabr (Chromium)
On 2016/04/07 00:29:24, dcheng wrote: > https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc > File ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc (right): > > https://codereview.chromium.org/1861593005/diff/1/ios/chrome/browser/passwords/ios_chrome_password_store_factory.cc#newcode7 > ...
4 years, 8 months ago (2016-04-07 02:05:30 UTC) #5
noyau (Ping after 24h)
Oh, my, that's a big CL. Thanks for doing this. I did a pass at ...
4 years, 8 months ago (2016-04-07 13:34:06 UTC) #7
rohitrao (ping after 24h)
Do these IWYU fixes need to be part of this mechanical CL, or can we ...
4 years, 8 months ago (2016-04-07 15:18:20 UTC) #8
noyau (Ping after 24h)
On 2016/04/07 15:18:20, rohitrao wrote: > Do these IWYU fixes need to be part of ...
4 years, 8 months ago (2016-04-07 18:44:50 UTC) #9
dcheng
I've addressed the various comments. I'd prefer not to make any further IWYU fixes in ...
4 years, 8 months ago (2016-04-07 18:48:33 UTC) #10
dcheng
On 2016/04/07 at 18:44:50, noyau wrote: > On 2016/04/07 15:18:20, rohitrao wrote: > > Do ...
4 years, 8 months ago (2016-04-07 18:51:47 UTC) #11
noyau (Ping after 24h)
lgtm
4 years, 8 months ago (2016-04-07 19:05:08 UTC) #12
noyau (Ping after 24h)
On 2016/04/07 18:51:47, dcheng wrote: > > > > I'm not fussy. It can be ...
4 years, 8 months ago (2016-04-07 19:09:02 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861593005/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861593005/60001
4 years, 8 months ago (2016-04-07 19:14:06 UTC) #16
commit-bot: I haz the power
Try jobs failed on following builders: ios_rel_device_gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_gn/builds/15828) mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, ...
4 years, 8 months ago (2016-04-07 19:19:12 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861593005/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861593005/80001
4 years, 8 months ago (2016-04-07 19:38:50 UTC) #21
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 8 months ago (2016-04-07 21:11:40 UTC) #22
commit-bot: I haz the power
4 years, 8 months ago (2016-04-07 21:29:21 UTC) #24
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/942f39d75745824a53ef6ce896bb2462010476bb
Cr-Commit-Position: refs/heads/master@{#385849}

Powered by Google App Engine
This is Rietveld 408576698