ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h - Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h

Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h

diff --git a/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h b/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h

index 2843bbd6fd689013f4192705e6ccd57798f68d1b..ca2bbcdb43ea53f71b14f6ac247eefe3f79ef969 100644

--- a/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h

+++ b/ios/chrome/browser/favicon/ios_chrome_favicon_loader_factory.h

@@ -5,8 +5,9 @@

#ifndef IOS_CHROME_BROWSER_FAVICON_IOS_CHROME_FAVICON_LOADER_FACTORY_H_

#define IOS_CHROME_BROWSER_FAVICON_IOS_CHROME_FAVICON_LOADER_FACTORY_H_

+#include <memory>

#include "base/macros.h"

-#include "base/memory/scoped_ptr.h"

#include "components/keyed_service/ios/browser_state_keyed_service_factory.h"

class FaviconLoader;

@@ -37,7 +38,7 @@ class IOSChromeFaviconLoaderFactory : public BrowserStateKeyedServiceFactory {

~IOSChromeFaviconLoaderFactory() override;

// BrowserStateKeyedServiceFactory implementation.

- scoped_ptr<KeyedService> BuildServiceInstanceFor(

+ std::unique_ptr<KeyedService> BuildServiceInstanceFor(

web::BrowserState* context) const override;

web::BrowserState* GetBrowserStateToUse(

web::BrowserState* context) const override;