ios/chrome/browser/signin/signin_manager_factory.cc - Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/signin/signin_manager_factory.cc

Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/signin/signin_manager_factory.cc

diff --git a/ios/chrome/browser/signin/signin_manager_factory.cc b/ios/chrome/browser/signin/signin_manager_factory.cc

index 201bc9927558d1160617268552195e2af61d9e5b..aef5a4b5adb259fa93a3676c30a8232821c6d834 100644

--- a/ios/chrome/browser/signin/signin_manager_factory.cc

+++ b/ios/chrome/browser/signin/signin_manager_factory.cc

@@ -79,11 +79,11 @@ void SigninManagerFactory::NotifyObserversOfSigninManagerCreationForTesting(

SigninManagerCreated(manager));

}

-scoped_ptr<KeyedService> SigninManagerFactory::BuildServiceInstanceFor(

+std::unique_ptr<KeyedService> SigninManagerFactory::BuildServiceInstanceFor(

web::BrowserState* context) const {

ios::ChromeBrowserState* chrome_browser_state =

ios::ChromeBrowserState::FromBrowserState(context);

- scoped_ptr<SigninManager> service(new SigninManager(

+ std::unique_ptr<SigninManager> service(new SigninManager(

SigninClientFactory::GetForBrowserState(chrome_browser_state),

OAuth2TokenServiceFactory::GetForBrowserState(chrome_browser_state),

ios::AccountTrackerServiceFactory::GetForBrowserState(