ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h - Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

Issue 1861593005: Convert //ios from scoped_ptr to std::unique_ptr. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase? Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/ui/webui/net_export/net_export_ui.cc ('k') | ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

diff --git a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

index 40c5f8928acbba56484198b34296642dbd14218f..6ff02ee2683b67dab5953ffa6bddfb6a2d529287 100644

--- a/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

+++ b/ios/chrome/browser/ui/webui/sync_internals/sync_internals_message_handler.h

@@ -5,6 +5,7 @@

#ifndef IOS_CHROME_BROWSER_UI_WEBUI_SYNC_INTERNALS_SYNC_INTERNALS_MESSAGE_HANDLER_H_

#define IOS_CHROME_BROWSER_UI_WEBUI_SYNC_INTERNALS_SYNC_INTERNALS_MESSAGE_HANDLER_H_

+#include <memory>

#include <string>

#include "base/macros.h"

@@ -52,7 +53,8 @@ class SyncInternalsMessageHandler : public web::WebUIIOSMessageHandler,

const syncer::JsEventDetails& details) override;

// Callback used in GetAllNodes.

- void OnReceivedAllNodes(int request_id, scoped_ptr<base::ListValue> nodes);

+ void OnReceivedAllNodes(int request_id,

+ std::unique_ptr<base::ListValue> nodes);

// sync_driver::SyncServiceObserver implementation.

void OnStateChanged() override;

@@ -75,7 +77,7 @@ class SyncInternalsMessageHandler : public web::WebUIIOSMessageHandler,

// counter type.

void EmitCounterUpdate(syncer::ModelType type,

const std::string& counter_type,

- scoped_ptr<base::DictionaryValue> value);

+ std::unique_ptr<base::DictionaryValue> value);

private:

// Fetches updated aboutInfo and sends it to the page in the form of an