Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(387)

Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator (Closed)

Created:
4 years, 8 months ago by kojii
Modified:
4 years, 8 months ago
Reviewers:
drott
CC:
blink-reviews, blink-reviews-platform-graphics_chromium.org, Rik, chromium-reviews, danakj+watch_chromium.org, dshwang, drott+blinkwatch_chromium.org, krit, f(malita), jbroman, Justin Novosad, kinuko+watch, pdr+graphicswatchlist_chromium.org, rwlbuis, Stephen Chennney, Seigo Nonaka
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator This patch includes two fixes for CachingWordShapeIterator not to delimit Hangul Tone Marks from base characters. The first fix is not to delmit non-CJK runs when it encounters CJK marks. The second fix is to exclude: U+302E HANGUL SINGLE DOT TONE MARK U+302F HANGUL DOUBLE DOT TONE MARK from the isCJKIdeographOrSymbol set. This change makes the Hangul tone marks consistent with other Hangul characters. BUG=594658 Committed: https://crrev.com/a7051b4065ce7dabe0e1ab758396f7e5c770d02d Cr-Commit-Position: refs/heads/master@{#385475}

Patch Set 1 #

Patch Set 2 : Add CharacterPropertyData.cpp #

Patch Set 3 : Add isCJKIdeographOrSymbolBase and fix test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -4 lines) Patch
M third_party/WebKit/Source/platform/fonts/Character.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterPropertyData.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/CharacterTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h View 1 2 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
kojii
PTAL.
4 years, 8 months ago (2016-04-06 07:20:40 UTC) #5
drott
LGTM, thanks for fixing this!
4 years, 8 months ago (2016-04-06 14:03:15 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1861033003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1861033003/40001
4 years, 8 months ago (2016-04-06 16:23:34 UTC) #8
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 8 months ago (2016-04-06 16:29:12 UTC) #9
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 16:30:14 UTC) #11
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/a7051b4065ce7dabe0e1ab758396f7e5c770d02d
Cr-Commit-Position: refs/heads/master@{#385475}

Powered by Google App Engine
This is Rietveld 408576698