third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h - Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add isCJKIdeographOrSymbolBase and fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/CharacterTest.cpp ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

index 2da5bef73ad79abb8f87e77408e4407bf5a5fed5..6418ecf870f0d61356e0fe13c352f6d42457dd1b 100644

--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h

@@ -154,7 +154,7 @@ private:

if (!m_textRun.is8Bit()) {

UChar32 nextChar;

U16_GET(m_textRun.characters16(), 0, i, length, nextChar);

- if (Character::isCJKIdeographOrSymbol(nextChar))

+ if (Character::isCJKIdeographOrSymbolBase(nextChar))

return i;

}