Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1038)

Unified Diff: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp

Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add isCJKIdeographOrSymbolBase and fix test Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
diff --git a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
index c3522a407610fc9040481fb4e1f0aefa1ea86e27..a8623c6063f09a4aa66ddbef068ad9deda1373fd 100644
--- a/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
+++ b/third_party/WebKit/Source/platform/fonts/shaping/CachingWordShaperTest.cpp
@@ -463,6 +463,24 @@ TEST_F(CachingWordShaperTest, SegmentCJKSmallFormVariants)
ASSERT_FALSE(iterator.next(&wordResult));
}
+TEST_F(CachingWordShaperTest, SegmentHangulToneMark)
+{
+ const UChar str[] = {
+ 0xC740, // HANGUL SYLLABLE EUN
+ 0x302E, // HANGUL SINGLE DOT TONE MARK
+ 0x0
+ };
+ TextRun textRun(str, 2);
+
+ RefPtr<ShapeResult> wordResult;
+ CachingWordShapeIterator iterator(cache.get(), textRun, &font);
+
+ ASSERT_TRUE(iterator.next(&wordResult));
+ EXPECT_EQ(2u, wordResult->numCharacters());
+
+ ASSERT_FALSE(iterator.next(&wordResult));
+}
+
TEST_F(CachingWordShaperTest, TextOrientationFallbackShouldNotInFallbackList)
{
const UChar str[] = {
« no previous file with comments | « third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698