third_party/WebKit/Source/platform/fonts/CharacterTest.cpp - Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

Issue 1861033003: Fix Hangul Tone Marks not to delimit in CachingWordShapeIterator (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add isCJKIdeographOrSymbolBase and fix test Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/platform/fonts/CharacterPropertyDataGenerator.h ('k') | third_party/WebKit/Source/platform/fonts/shaping/CachingWordShapeIterator.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

diff --git a/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp b/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

index 419561a155687d335c02dddf4a643e3bf56636c3..ceb3b86c336770c918ac52499e90638371f78f73 100644

--- a/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

+++ b/third_party/WebKit/Source/platform/fonts/CharacterTest.cpp

@@ -306,7 +306,7 @@ TEST(CharacterTest, TestIsCJKIdeographOrSymbol)

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0x2B1A));

- TestSpecificUChar32RangeIdeographSymbol(0x2FF0, 0x302F);

+ TestSpecificUChar32RangeIdeographSymbol(0x2FF0, 0x302D);

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0x3031));

EXPECT_TRUE(Character::isCJKIdeographOrSymbol(0x312F));

EXPECT_FALSE(Character::isCJKIdeographOrSymbol(0x3130));