[Telemetry] Ignore non-scalar numerics for TBMv2 metrics

[Telemetry] Ignore non-scalar numerics for TBMv2 metrics

TBMv2 metrics can and should add Numeric instances for their metrics. We
flatten these on the metric side into a group of scalars, but leave the
original numerics in place.

This CL makes it so that timeline_based_measurement will ignore non-scalar
numerics.

BUG=catapult:#2209
R=nednguyen

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/e2ce6230ec26e8e8d9911fad34f7c95f3e9c0f83

[eakuefner, 2016-04-04 21:53:31]

PTAL

[nednguyen, 2016-04-04 22:12:08]

lgtm

After address the comments, you can land this.

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
File telemetry/telemetry/web_perf/timeline_based_measurement.py (right):

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
telemetry/telemetry/web_perf/timeline_based_measurement.py:312: if d.get('type')
== 'numeric' and d['numeric'].get('type') == 'scalar':
nits: instead of doing the querying here, can you do
translate_common_values.IsScalarNumberic(d)? Then we can also add an assertion
in TranslateScalarValue for that as well.

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
telemetry/telemetry/web_perf/timeline_based_measurement.py:314:
translate_common_values.TranslateScalarValue(d, page))
nits: we probably should rename this to common_values_translator, maybe
different cl though

[eakuefner, 2016-04-04 22:25:13]

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
File telemetry/telemetry/web_perf/timeline_based_measurement.py (right):

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
telemetry/telemetry/web_perf/timeline_based_measurement.py:312: if d.get('type')
== 'numeric' and d['numeric'].get('type') == 'scalar':
On 2016/04/04 at 22:12:08, nednguyen wrote:
> nits: instead of doing the querying here, can you do
translate_common_values.IsScalarNumberic(d)? Then we can also add an assertion
in TranslateScalarValue for that as well.

Done.

https://codereview.chromium.org/1860753003/diff/20001/telemetry/telemetry/web...
telemetry/telemetry/web_perf/timeline_based_measurement.py:314:
translate_common_values.TranslateScalarValue(d, page))
On 2016/04/04 at 22:12:08, nednguyen wrote:
> nits: we probably should rename this to common_values_translator, maybe
different cl though

Opened https://github.com/catapult-project/catapult/issues/2213

I think that common_value_helpers is probably better than
common_value_translator, since it's a collection of static helpers, rather than
a class.

[eakuefner, 2016-04-04 22:25:23]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-04-04 22:25:24]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1860753003/#ps40001
(title: "Address Ned's comment")

[commit-bot: I haz the power, 2016-04-04 22:25:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1860753003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1860753003/40001

[commit-bot: I haz the power, 2016-04-04 22:45:15]

Description was changed from

==========
[Telemetry] Ignore non-scalar numerics for TBMv2 metrics

TBMv2 metrics can and should add Numeric instances for their metrics. We
flatten these on the metric side into a group of scalars, but leave the
original numerics in place.

This CL makes it so that timeline_based_measurement will ignore non-scalar
numerics.

BUG=catapult:#2209
R=nednguyen
==========

to

==========
[Telemetry] Ignore non-scalar numerics for TBMv2 metrics

TBMv2 metrics can and should add Numeric instances for their metrics. We
flatten these on the metric side into a group of scalars, but leave the
original numerics in place.

This CL makes it so that timeline_based_measurement will ignore non-scalar
numerics.

BUG=catapult:#2209
R=nednguyen

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-04-04 22:45:18]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...