Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(158)

Unified Diff: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

Issue 1860753003: [Telemetry] Ignore non-scalar numerics for TBMv2 metrics (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Address Ned's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
diff --git a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
index afba9e8085f504f2c600b848bc1afd3f0bac2fb0..d741be7ad91521e8a428e90338e759596e98af00 100644
--- a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
+++ b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py
@@ -120,9 +120,15 @@ class TimelineBasedPageTestTest(page_test_test_case.PageTestTestCase):
self.assertEquals(0, len(results.failures))
v_foo = results.FindAllPageSpecificValuesNamed('foo')
v_bar = results.FindAllPageSpecificValuesNamed('bar')
+ v_baz_avg = results.FindAllPageSpecificValuesNamed('baz_avg')
+ v_baz_sum = results.FindAllPageSpecificValuesNamed('baz_sum')
+ v_baz_count = results.FindAllPageSpecificValuesNamed('baz_count')
self.assertEquals(len(v_foo), 1)
self.assertEquals(len(v_bar), 1)
self.assertEquals(v_foo[0].value, 1)
self.assertIsNotNone(v_foo[0].page)
self.assertEquals(v_bar[0].value, 2)
self.assertIsNotNone(v_bar[0].page)
+ self.assertEquals(len(v_baz_avg), 1)
+ self.assertEquals(len(v_baz_sum), 1)
+ self.assertEquals(len(v_baz_count), 1)
« no previous file with comments | « telemetry/telemetry/web_perf/timeline_based_measurement.py ('k') | tracing/tracing/metrics/sample_metric.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698