telemetry/telemetry/web_perf/timeline_based_measurement.py - Issue 1860753003: [Telemetry] Ignore non-scalar numerics for TBMv2 metrics

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/web_perf/timeline_based_measurement.py

Issue 1860753003: [Telemetry] Ignore non-scalar numerics for TBMv2 metrics (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Address Ned's comment Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/web_perf/timeline_based_measurement.py

diff --git a/telemetry/telemetry/web_perf/timeline_based_measurement.py b/telemetry/telemetry/web_perf/timeline_based_measurement.py

index 31f31255b75370cdaf363fb9bb49671233724534..ff3fd142f1a384d1bab5b3658b16966aabf7d73f 100644

--- a/telemetry/telemetry/web_perf/timeline_based_measurement.py

+++ b/telemetry/telemetry/web_perf/timeline_based_measurement.py

@@ -309,8 +309,9 @@ class TimelineBasedMeasurement(story_test.StoryTest):

value_dicts = mre_result.pairs.get('values', [])

for d in value_dicts:

- results.AddValue(

- translate_common_values.TranslateScalarValue(d, page))

+ if translate_common_values.IsScalarNumericValue(d):

+ results.AddValue(

+ translate_common_values.TranslateScalarValue(d, page))

def _ComputeLegacyTimelineBasedMetrics(self, results, trace_result):

model = model_module.TimelineModel(trace_result)