Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(432)

Unified Diff: telemetry/telemetry/value/translate_common_values.py

Issue 1860753003: [Telemetry] Ignore non-scalar numerics for TBMv2 metrics (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Address Ned's comment Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: telemetry/telemetry/value/translate_common_values.py
diff --git a/telemetry/telemetry/value/translate_common_values.py b/telemetry/telemetry/value/translate_common_values.py
index b9bdfe03c345d5690d5b6f05f5441cca67fd7e66..4aadcd1dc68a0d465c39173f96dfb079e93ca867 100644
--- a/telemetry/telemetry/value/translate_common_values.py
+++ b/telemetry/telemetry/value/translate_common_values.py
@@ -11,8 +11,7 @@ def TranslateMreFailure(mre_failure, page):
def TranslateScalarValue(scalar_value, page):
- assert (scalar_value['type'] == 'numeric' and
- scalar_value['numeric']['type'] == 'scalar')
+ assert IsScalarNumericValue(scalar_value)
scalar_value['value'] = scalar_value['numeric']['value']
name = scalar_value['grouping_keys']['name']
@@ -33,3 +32,8 @@ def TranslateScalarValue(scalar_value, page):
scalar_value['name'] = name
del scalar_value['grouping_keys']['name']
return scalar.ScalarValue.FromDict(scalar_value, {page.id: page})
+
+
+def IsScalarNumericValue(value_dict):
+ return (value_dict.get('type') == 'numeric' and
+ value_dict['numeric'].get('type') == 'scalar')
« no previous file with comments | « no previous file | telemetry/telemetry/web_perf/timeline_based_measurement.py » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698