Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(726)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1859343004: dartfmt pkg/compiler (Closed)

Created:
4 years, 8 months ago by Harry Terkelsen
Modified:
4 years, 8 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21192 lines, -32195 lines) Patch
M pkg/compiler/lib/compiler.dart View 1 2 4 chunks +12 lines, -17 lines 0 comments Download
M pkg/compiler/lib/compiler_new.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/apiimpl.dart View 1 2 18 chunks +55 lines, -79 lines 0 comments Download
M pkg/compiler/lib/src/cache_strategy.dart View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/closure.dart View 1 2 30 chunks +81 lines, -105 lines 0 comments Download
M pkg/compiler/lib/src/common.dart View 1 2 1 chunk +12 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/common/backend_api.dart View 1 2 7 chunks +60 lines, -104 lines 0 comments Download
M pkg/compiler/lib/src/common/codegen.dart View 1 2 10 chunks +38 lines, -57 lines 0 comments Download
M pkg/compiler/lib/src/common/names.dart View 1 2 3 chunks +20 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/common/registry.dart View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/common/resolution.dart View 1 2 8 chunks +51 lines, -48 lines 0 comments Download
M pkg/compiler/lib/src/common/tasks.dart View 1 2 3 chunks +6 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/common/work.dart View 1 2 1 chunk +5 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/compile_time_constants.dart View 1 2 38 chunks +160 lines, -111 lines 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 1 2 45 chunks +218 lines, -314 lines 0 comments Download
M pkg/compiler/lib/src/constant_system_dart.dart View 1 2 13 chunks +18 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_constructors.dart View 1 2 13 chunks +59 lines, -113 lines 0 comments Download
M pkg/compiler/lib/src/constants/constant_system.dart View 1 2 3 chunks +54 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/constants/constructors.dart View 1 2 8 chunks +20 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/constants/evaluation.dart View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/constants/expressions.dart View 1 2 54 chunks +121 lines, -165 lines 0 comments Download
M pkg/compiler/lib/src/constants/values.dart View 1 2 20 chunks +58 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/backward_null_check_remover.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/bounds_checker.dart View 1 2 3 chunks +15 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/builtin_operator.dart View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_fragment.dart View 1 2 4 chunks +20 lines, -26 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder.dart View 1 2 91 chunks +381 lines, -494 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 1 2 131 chunks +802 lines, -1111 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_integrity.dart View 1 2 5 chunks +11 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes.dart View 1 2 10 chunks +19 lines, -46 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_nodes_sexpr.dart View 1 2 9 chunks +18 lines, -19 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/cps_ir_tracer.dart View 1 2 6 chunks +11 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/eagerly_load_statics.dart View 1 2 2 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/effects.dart View 1 2 4 chunks +8 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/finalize.dart View 1 2 3 chunks +22 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/gvn.dart View 1 2 7 chunks +17 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/inline.dart View 1 2 13 chunks +53 lines, -65 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/insert_refinements.dart View 1 2 9 chunks +18 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_effects.dart View 1 2 1 chunk +2 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_hierarchy.dart View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/loop_invariant_branch.dart View 1 2 3 chunks +8 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/mutable_ssa.dart View 1 2 3 chunks +5 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/octagon.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimize_interceptors.dart View 1 2 6 chunks +21 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/optimizers.dart View 1 2 2 chunks +8 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/parent_visitor.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/cps_ir/path_based_optimizer.dart View 1 2 3 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_join.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_phi.dart View 1 2 2 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/redundant_refinement.dart View 1 2 2 chunks +4 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/scalar_replacement.dart View 1 2 6 chunks +6 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/shrinking_reductions.dart View 1 2 11 chunks +22 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_mask_system.dart View 1 2 12 chunks +27 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/type_propagation.dart View 1 2 107 chunks +306 lines, -377 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/update_refinements.dart View 1 2 3 chunks +6 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/cps_ir/use_field_initializers.dart View 1 2 2 chunks +9 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/dart2js.dart View 1 2 15 chunks +66 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/dart2js_profile_many.dart View 1 2 3 chunks +2 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/dart2js_stress.dart View 1 2 2 chunks +10 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend.dart View 1 2 17 chunks +53 lines, -68 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_emitter.dart View 1 2 4 chunks +15 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_nodes.dart View 1 2 33 chunks +82 lines, -98 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/backend_ast_to_frontend_ast.dart View 1 2 52 chunks +228 lines, -232 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/dart_backend.dart View 1 2 1 chunk +15 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/outputter.dart View 1 2 26 chunks +70 lines, -99 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/placeholder_collector.dart View 1 2 17 chunks +45 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/dart_backend/renamer.dart View 1 2 20 chunks +63 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/dart_types.dart View 1 2 44 chunks +109 lines, -145 lines 0 comments Download
M pkg/compiler/lib/src/deferred_load.dart View 1 2 26 chunks +123 lines, -147 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/diagnostic_listener.dart View 1 2 3 chunks +13 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/invariant.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/diagnostics/messages.dart View 1 2 38 chunks +1433 lines, -1345 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/source_span.dart View 1 2 2 chunks +5 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/diagnostics/spannable.dart View 1 2 2 chunks +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/dump_info.dart View 1 2 2 chunks +20 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/elements/common.dart View 1 2 16 chunks +26 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/elements/elements.dart View 1 2 18 chunks +81 lines, -99 lines 0 comments Download
M pkg/compiler/lib/src/elements/modelx.dart View 1 2 86 chunks +291 lines, -392 lines 0 comments Download
M pkg/compiler/lib/src/elements/names.dart View 1 2 2 chunks +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/elements/visitor.dart View 1 2 3 chunks +2 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/enqueue.dart View 1 2 30 chunks +125 lines, -151 lines 0 comments Download
M pkg/compiler/lib/src/hash/sha1.dart View 1 2 10 chunks +24 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/helpers/debug_collection.dart View 1 2 10 chunks +10 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_map.dart View 1 2 2 chunks +2 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/helpers/expensive_set.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/helpers/helpers.dart View 1 2 4 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/helpers/stats.dart View 1 2 16 chunks +39 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/helpers/trace.dart View 1 2 15 chunks +62 lines, -77 lines 0 comments Download
M pkg/compiler/lib/src/helpers/track_map.dart View 1 2 3 chunks +3 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/closure_tracer.dart View 1 2 5 chunks +11 lines, -11 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/inferrer_visitor.dart View 1 2 28 chunks +90 lines, -160 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/list_tracer.dart View 1 2 2 chunks +114 lines, -117 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/map_tracer.dart View 1 2 2 chunks +21 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/node_tracer.dart View 1 2 11 chunks +71 lines, -74 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/simple_types_inferrer.dart View 1 2 59 chunks +329 lines, -696 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_dump.dart View 1 2 10 chunks +23 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_inferrer.dart View 1 2 33 chunks +189 lines, -223 lines 0 comments Download
M pkg/compiler/lib/src/inferrer/type_graph_nodes.dart View 1 2 45 chunks +150 lines, -160 lines 0 comments Download
M pkg/compiler/lib/src/info/naive_analysis_result.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/info/send_info.dart View 1 2 49 chunks +228 lines, -234 lines 0 comments Download
M pkg/compiler/lib/src/info/trusted_types_analysis_result.dart View 1 2 5 chunks +23 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/io/code_output.dart View 1 2 3 chunks +7 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/io/position_information.dart View 1 2 32 chunks +66 lines, -113 lines 0 comments Download
M pkg/compiler/lib/src/io/source_file.dart View 1 2 7 chunks +9 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/io/source_information.dart View 1 2 2 chunks +7 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/io/source_map_builder.dart View 1 2 7 chunks +11 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/io/start_end_information.dart View 1 2 5 chunks +13 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js/js.dart View 1 2 7 chunks +16 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js/js_debug.dart View 1 2 1 chunk +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js/js_source_mapping.dart View 1 2 2 chunks +6 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js/placeholder_safety.dart View 1 2 7 chunks +9 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/js/rewrite_async.dart View 1 2 47 chunks +197 lines, -213 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend.dart View 1 2 90 chunks +289 lines, -376 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_helpers.dart View 1 2 9 chunks +23 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_impact.dart View 1 2 44 chunks +168 lines, -213 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_serialization.dart View 1 2 2 chunks +3 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/checked_mode_helpers.dart View 1 2 6 chunks +43 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/codegen.dart View 1 2 42 chunks +138 lines, -172 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/glue.dart View 1 2 3 chunks +11 lines, -22 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/task.dart View 1 2 12 chunks +36 lines, -41 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/codegen/unsugar.dart View 1 2 4 chunks +9 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_emitter.dart View 1 2 9 chunks +42 lines, -45 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_handler_javascript.dart View 1 2 10 chunks +30 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/constant_system_javascript.dart View 1 2 9 chunks +26 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/custom_elements_analysis.dart View 1 2 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/field_naming_mixin.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/frequency_namer.dart View 1 2 3 chunks +10 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_backend.dart View 1 2 1 chunk +47 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/js_interop_analysis.dart View 1 2 6 chunks +23 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/lookup_map_analysis.dart View 1 2 8 chunks +33 lines, -32 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/minify_namer.dart View 1 2 11 chunks +133 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer.dart View 1 2 44 chunks +147 lines, -149 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/namer_names.dart View 1 2 6 chunks +7 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/native_data.dart View 1 2 6 chunks +21 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/no_such_method_registry.dart View 1 2 5 chunks +21 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/patch_resolver.dart View 1 2 6 chunks +44 lines, -51 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/runtime_types.dart View 1 2 32 chunks +80 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/type_variable_handler.dart View 1 2 5 chunks +15 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/class_stub_generator.dart View 1 2 14 chunks +55 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/code_emitter_task.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/constant_ordering.dart View 1 2 3 chunks +5 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_builder.dart View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/class_emitter.dart View 1 2 15 chunks +56 lines, -69 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/container_builder.dart View 1 2 5 chunks +21 lines, -23 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/declarations.dart View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart View 1 2 72 chunks +391 lines, -392 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/interceptor_emitter.dart View 1 2 4 chunks +14 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/nsm_emitter.dart View 1 2 11 chunks +49 lines, -44 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/full_emitter/setup_program_builder.dart View 1 2 4 chunks +77 lines, -78 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/headers.dart View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart View 1 2 14 chunks +76 lines, -63 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/js_emitter.dart View 1 2 1 chunk +58 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/emitter.dart View 1 2 4 chunks +18 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/lazy_emitter/model_emitter.dart View 1 2 30 chunks +177 lines, -165 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/main_call_stub_generator.dart View 1 2 4 chunks +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/metadata_collector.dart View 1 2 11 chunks +33 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/model.dart View 1 2 16 chunks +141 lines, -143 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_emitter.dart View 1 2 10 chunks +21 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/native_generator.dart View 1 2 8 chunks +21 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/parameter_stub_generator.dart View 1 2 9 chunks +24 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/collector.dart View 1 2 8 chunks +39 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart View 1 2 5 chunks +21 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart View 1 2 31 chunks +141 lines, -175 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/program_builder/registry.dart View 1 2 1 chunk +2 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/runtime_type_generator.dart View 1 2 11 chunks +46 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/emitter.dart View 1 2 6 chunks +20 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart View 1 2 28 chunks +183 lines, -172 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/startup_emitter/model_emitter.dart View 1 2 14 chunks +75 lines, -94 lines 0 comments Download
M pkg/compiler/lib/src/js_emitter/type_test_registry.dart View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/library_loader.dart View 1 2 38 chunks +124 lines, -169 lines 0 comments Download
M pkg/compiler/lib/src/mirror_renamer/mirror_renamer.dart View 1 2 2 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/mirror_renamer/renamer.dart View 1 2 2 chunks +5 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/analyze.dart View 1 2 2 chunks +12 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_instance_mirrors.dart View 1 2 14 chunks +24 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_library_mirror.dart View 1 2 4 chunks +8 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_member_mirrors.dart View 1 2 10 chunks +29 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_mirrors.dart View 1 2 17 chunks +38 lines, -47 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/dart2js_type_mirrors.dart View 1 2 16 chunks +36 lines, -49 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/mirrors_util.dart View 1 2 9 chunks +20 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/mirrors/source_mirrors.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/mirrors_used.dart View 1 2 16 chunks +61 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/native/behavior.dart View 1 2 25 chunks +92 lines, -131 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 2 16 chunks +46 lines, -75 lines 0 comments Download
M pkg/compiler/lib/src/native/js.dart View 1 2 5 chunks +5 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/native/native.dart View 1 2 1 chunk +16 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/native/scanner.dart View 1 2 1 chunk +4 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/native/ssa.dart View 1 2 3 chunks +18 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/old_to_new_api.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ordered_typeset.dart View 1 2 6 chunks +14 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/parser/class_element_parser.dart View 1 2 1 chunk +4 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/parser/diet_parser_task.dart View 1 2 2 chunks +9 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/parser/element_listener.dart View 1 2 23 chunks +101 lines, -127 lines 0 comments Download
M pkg/compiler/lib/src/parser/listener.dart View 1 2 5 chunks +219 lines, -406 lines 0 comments Download
M pkg/compiler/lib/src/parser/member_listener.dart View 1 2 4 chunks +26 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/parser/node_listener.dart View 1 2 26 chunks +86 lines, -117 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser.dart View 1 2 37 chunks +156 lines, -184 lines 0 comments Download
M pkg/compiler/lib/src/parser/parser_task.dart View 1 2 2 chunks +14 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_elements.dart View 1 2 16 chunks +95 lines, -133 lines 0 comments Download
M pkg/compiler/lib/src/parser/partial_parser.dart View 1 2 1 chunk +7 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/patch_parser.dart View 1 2 23 chunks +118 lines, -198 lines 0 comments Download
M pkg/compiler/lib/src/platform_configuration.dart View 1 2 1 chunk +3 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 1 2 7 chunks +14 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_hierarchy.dart View 1 2 24 chunks +89 lines, -137 lines 0 comments Download
M pkg/compiler/lib/src/resolution/class_members.dart View 1 2 32 chunks +213 lines, -230 lines 0 comments Download
M pkg/compiler/lib/src/resolution/constructors.dart View 1 2 32 chunks +132 lines, -153 lines 0 comments Download
M pkg/compiler/lib/src/resolution/enum_creator.dart View 1 2 14 chunks +55 lines, -76 lines 0 comments Download
M pkg/compiler/lib/src/resolution/label_scope.dart View 1 2 3 chunks +6 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/resolution/member_impl.dart View 1 2 11 chunks +17 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 1 2 171 chunks +536 lines, -755 lines 0 comments Download
M pkg/compiler/lib/src/resolution/operators.dart View 1 2 6 chunks +171 lines, -128 lines 0 comments Download
M pkg/compiler/lib/src/resolution/registry.dart View 1 2 12 chunks +41 lines, -68 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution.dart View 1 2 34 chunks +195 lines, -236 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_common.dart View 1 2 5 chunks +18 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/resolution/resolution_result.dart View 1 2 2 chunks +4 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/resolution/scope.dart View 1 2 5 chunks +6 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/resolution/secret_tree_element.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 2 333 chunks +480 lines, -1717 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 1 2 134 chunks +2000 lines, -6280 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_resolver.dart View 1 2 10 chunks +23 lines, -36 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 1 2 64 chunks +333 lines, -1084 lines 0 comments Download
M pkg/compiler/lib/src/resolution/signatures.dart View 1 2 16 chunks +75 lines, -82 lines 0 comments Download
M pkg/compiler/lib/src/resolution/tree_elements.dart View 1 2 5 chunks +17 lines, -20 lines 0 comments Download
M pkg/compiler/lib/src/resolution/type_resolver.dart View 1 2 12 chunks +61 lines, -80 lines 0 comments Download
M pkg/compiler/lib/src/resolution/typedefs.dart View 1 2 2 chunks +25 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/resolution/variables.dart View 1 2 4 chunks +17 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/scanner/array_based_scanner.dart View 1 2 3 chunks +16 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner.dart View 1 2 12 chunks +32 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/scanner/scanner_task.dart View 1 2 2 chunks +9 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/scanner/string_scanner.dart View 1 2 2 chunks +10 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/scanner/utf8_bytes_scanner.dart View 1 2 3 chunks +7 lines, -14 lines 0 comments Download
M pkg/compiler/lib/src/script.dart View 1 2 2 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/serialization/constant_serialization.dart View 1 2 21 chunks +57 lines, -92 lines 0 comments Download
M pkg/compiler/lib/src/serialization/element_serialization.dart View 1 2 20 chunks +51 lines, -70 lines 0 comments Download
M pkg/compiler/lib/src/serialization/equivalence.dart View 1 2 17 chunks +154 lines, -256 lines 0 comments Download
M pkg/compiler/lib/src/serialization/impact_serialization.dart View 1 2 5 chunks +25 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/serialization/json_serializer.dart View 1 2 3 chunks +4 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/serialization/modelz.dart View 1 2 45 chunks +140 lines, -197 lines 0 comments Download
M pkg/compiler/lib/src/serialization/serialization.dart View 1 2 9 chunks +10 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/serialization/task.dart View 1 2 1 chunk +6 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/serialization/type_serialization.dart View 1 2 4 chunks +10 lines, -24 lines 0 comments Download
M pkg/compiler/lib/src/serialization/values.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/source_file_provider.dart View 1 2 8 chunks +37 lines, -43 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 1 2 269 chunks +1136 lines, -1928 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen.dart View 1 2 84 chunks +345 lines, -400 lines 0 comments Download
M pkg/compiler/lib/src/ssa/codegen_helpers.dart View 1 2 15 chunks +30 lines, -38 lines 0 comments Download
M pkg/compiler/lib/src/ssa/interceptor_simplifier.dart View 1 2 9 chunks +25 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/ssa/invoke_dynamic_specializers.dart View 1 2 44 chunks +117 lines, -136 lines 0 comments Download
M pkg/compiler/lib/src/ssa/nodes.dart View 1 2 105 chunks +298 lines, -381 lines 0 comments Download
M pkg/compiler/lib/src/ssa/optimize.dart View 1 2 60 chunks +191 lines, -236 lines 0 comments Download
M pkg/compiler/lib/src/ssa/ssa_tracer.dart View 1 2 10 chunks +30 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types.dart View 1 2 1 chunk +9 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/types_propagation.dart View 1 2 10 chunks +45 lines, -52 lines 0 comments Download
M pkg/compiler/lib/src/ssa/validate.dart View 1 2 6 chunks +15 lines, -13 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_range_analyzer.dart View 1 2 24 chunks +64 lines, -66 lines 0 comments Download
M pkg/compiler/lib/src/ssa/value_set.dart View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/variable_allocator.dart View 1 2 15 chunks +38 lines, -40 lines 0 comments Download
M pkg/compiler/lib/src/string_validator.dart View 1 2 9 chunks +16 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/tokens/keyword.dart View 1 2 7 chunks +83 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/tokens/precedence.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tokens/precedence_constants.dart View 1 2 2 chunks +76 lines, -128 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token.dart View 1 2 11 chunks +22 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/tokens/token_map.dart View 1 2 3 chunks +5 lines, -6 lines 0 comments Download
M pkg/compiler/lib/src/tracer.dart View 1 2 4 chunks +11 lines, -21 lines 0 comments Download
M pkg/compiler/lib/src/tree/dartstring.dart View 1 2 7 chunks +23 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/tree/nodes.dart View 1 2 58 chunks +170 lines, -138 lines 0 comments Download
M pkg/compiler/lib/src/tree/prettyprint.dart View 1 2 12 chunks +19 lines, -27 lines 0 comments Download
M pkg/compiler/lib/src/tree/unparser.dart View 1 2 13 chunks +19 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/logical_rewriter.dart View 1 2 11 chunks +43 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/loop_rewriter.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/pull_into_initializers.dart View 1 2 1 chunk +1 line, -2 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/statement_rewriter.dart View 1 2 10 chunks +33 lines, -35 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/optimization/variable_merger.dart View 1 2 8 chunks +13 lines, -16 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_builder.dart View 1 2 22 chunks +109 lines, -138 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_integrity.dart View 1 2 2 chunks +4 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_nodes.dart View 1 2 25 chunks +57 lines, -78 lines 0 comments Download
M pkg/compiler/lib/src/tree_ir/tree_ir_tracer.dart View 1 2 6 chunks +10 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/typechecker.dart View 1 2 58 chunks +253 lines, -246 lines 0 comments Download
M pkg/compiler/lib/src/types/abstract_value_domain.dart View 1 2 4 chunks +6 lines, -9 lines 0 comments Download
M pkg/compiler/lib/src/types/constants.dart View 1 2 4 chunks +8 lines, -10 lines 0 comments Download
M pkg/compiler/lib/src/types/container_type_mask.dart View 1 2 4 chunks +16 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/types/dictionary_type_mask.dart View 1 2 3 chunks +28 lines, -42 lines 0 comments Download
M pkg/compiler/lib/src/types/flat_type_mask.dart View 1 2 20 chunks +71 lines, -74 lines 0 comments Download
M pkg/compiler/lib/src/types/forwarding_type_mask.dart View 1 2 3 chunks +3 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/types/map_type_mask.dart View 1 2 4 chunks +20 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/types/type_mask.dart View 1 2 9 chunks +11 lines, -17 lines 0 comments Download
M pkg/compiler/lib/src/types/types.dart View 1 2 4 chunks +19 lines, -30 lines 0 comments Download
M pkg/compiler/lib/src/types/union_type_mask.dart View 1 2 7 chunks +18 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/types/value_type_mask.dart View 1 2 2 chunks +3 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/universe/call_structure.dart View 1 2 5 chunks +8 lines, -15 lines 0 comments Download
M pkg/compiler/lib/src/universe/class_set.dart View 1 2 24 chunks +53 lines, -85 lines 0 comments Download
M pkg/compiler/lib/src/universe/function_set.dart View 1 2 4 chunks +14 lines, -29 lines 0 comments Download
M pkg/compiler/lib/src/universe/selector.dart View 1 2 9 chunks +74 lines, -89 lines 0 comments Download
M pkg/compiler/lib/src/universe/side_effects.dart View 1 2 4 chunks +46 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/universe/universe.dart View 1 2 7 chunks +20 lines, -31 lines 0 comments Download
M pkg/compiler/lib/src/universe/use.dart View 1 2 10 chunks +36 lines, -50 lines 0 comments Download
M pkg/compiler/lib/src/universe/world_impact.dart View 1 2 8 chunks +14 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/use_unused_api.dart View 1 2 6 chunks +32 lines, -39 lines 0 comments Download
M pkg/compiler/lib/src/util/characters.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/command_line.dart View 1 2 3 chunks +10 lines, -12 lines 0 comments Download
M pkg/compiler/lib/src/util/emptyset.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/enumset.dart View 1 2 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/util/indentation.dart View 1 2 2 chunks +6 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/util/link.dart View 1 2 5 chunks +7 lines, -8 lines 0 comments Download
M pkg/compiler/lib/src/util/link_implementation.dart View 1 2 4 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/util/maplet.dart View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/util/setlet.dart View 1 2 3 chunks +6 lines, -3 lines 0 comments Download
M pkg/compiler/lib/src/util/uri_extras.dart View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
M pkg/compiler/lib/src/util/util.dart View 1 2 4 chunks +24 lines, -18 lines 0 comments Download
M pkg/compiler/lib/src/world.dart View 1 2 21 chunks +61 lines, -81 lines 0 comments Download
M pkg/compiler/samples/compile_loop/compile_loop.dart View 1 2 1 chunk +11 lines, -14 lines 0 comments Download
M pkg/compiler/samples/darttags/darttags.dart View 1 2 4 chunks +8 lines, -14 lines 0 comments Download
M pkg/compiler/samples/jsonify/jsonify.dart View 1 2 3 chunks +11 lines, -15 lines 0 comments Download
M pkg/compiler/tool/track_memory.dart View 1 2 2 chunks +5 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Harry Terkelsen
4 years, 8 months ago (2016-04-06 20:54:42 UTC) #2
Siggi Cherem (dart-lang)
lgtm! - STV! https://codereview.chromium.org/1859343004/diff/1/pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (right): https://codereview.chromium.org/1859343004/diff/1/pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart#newcode5 pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:5: DON'T EDIT. GENERATED. DON'T EDIT. revert ...
4 years, 8 months ago (2016-04-07 16:15:25 UTC) #3
Harry Terkelsen
https://codereview.chromium.org/1859343004/diff/1/pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart File pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart (right): https://codereview.chromium.org/1859343004/diff/1/pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart#newcode5 pkg/compiler/lib/src/diagnostics/generated/shared_messages.dart:5: DON'T EDIT. GENERATED. DON'T EDIT. On 2016/04/07 16:15:24, Siggi ...
4 years, 8 months ago (2016-04-07 16:52:29 UTC) #4
Harry Terkelsen
4 years, 8 months ago (2016-04-07 17:01:01 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:20001) manually as
29cf47713986fce2cf478ab3c1e0f8c301fa1f28 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698