Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(784)

Unified Diff: pkg/compiler/lib/src/js/placeholder_safety.dart

Issue 1859343004: dartfmt pkg/compiler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/js/js_source_mapping.dart ('k') | pkg/compiler/lib/src/js/rewrite_async.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/js/placeholder_safety.dart
diff --git a/pkg/compiler/lib/src/js/placeholder_safety.dart b/pkg/compiler/lib/src/js/placeholder_safety.dart
index b103489dada8fd20a806408d003c7f5cd3f2a957..62140eaeada60df270cc97065bcfb909a87fd4ad 100644
--- a/pkg/compiler/lib/src/js/placeholder_safety.dart
+++ b/pkg/compiler/lib/src/js/placeholder_safety.dart
@@ -2,7 +2,6 @@
// for details. All rights reserved. Use of this source code is governed by a
// BSD-style license that can be found in the LICENSE file.
-
library js.safety;
import "js.dart" as js;
@@ -29,8 +28,8 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
// exceptions. The possible values of expressions are represented by
// integers. Small non-negative integers 0, 1, 2, ... represent the values of
// the placeholders. Other values are:
- static const int NONNULL_VALUE = -1; // Unknown but not null.
- static const int UNKNOWN_VALUE = -2; // Unknown and might be null.
+ static const int NONNULL_VALUE = -1; // Unknown but not null.
+ static const int UNKNOWN_VALUE = -2; // Unknown and might be null.
PlaceholderSafetyAnalysis._(this.isNullableInput);
@@ -147,14 +146,14 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
safe = false;
return leftToRight();
}
-
+
// Assignment operators dereference the LHS before evaluating the RHS.
if (node.op != null) return leftToRight();
// Assignment (1) evaluates the LHS as a Reference `lval`, (2) evaluates the
// RHS as a value, (3) dereferences the `lval` in PutValue.
if (left is js.VariableReference) {
- int value = visit(right);
+ int value = visit(right);
// Assignment could change an observed global or cause a ReferenceError.
safe = false;
return value;
@@ -213,7 +212,7 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
case "|":
int left = visit(node.left);
int right = visit(node.right);
- return NONNULL_VALUE; // Number, String, Boolean.
+ return NONNULL_VALUE; // Number, String, Boolean.
case ',':
int left = visit(node.left);
@@ -258,7 +257,7 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
// "typeof a" first evaluates to a Reference. If the Reference is to a
// variable that is not present, "undefined" is returned without
// dereferencing.
- if (node.argument is js.VariableUse) return NONNULL_VALUE; // A string.
+ if (node.argument is js.VariableUse) return NONNULL_VALUE; // A string.
}
visit(node.argument);
@@ -273,14 +272,14 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
return NONNULL_VALUE;
case 'typeof':
- return NONNULL_VALUE; // Always a string.
+ return NONNULL_VALUE; // Always a string.
case 'void':
return UNKNOWN_VALUE;
case '--':
case '++':
- return NONNULL_VALUE; // Always a number.
+ return NONNULL_VALUE; // Always a number.
default:
safe = false;
@@ -291,7 +290,7 @@ class PlaceholderSafetyAnalysis extends js.BaseVisitor<int> {
int visitPostfix(js.Postfix node) {
assert(node.op == '--' || node.op == '++');
visit(node.argument);
- return NONNULL_VALUE; // Always a number, even for "(a=null, a++)".
+ return NONNULL_VALUE; // Always a number, even for "(a=null, a++)".
}
int visitVariableUse(js.VariableUse node) {
« no previous file with comments | « pkg/compiler/lib/src/js/js_source_mapping.dart ('k') | pkg/compiler/lib/src/js/rewrite_async.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698