Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Unified Diff: pkg/compiler/lib/src/ssa/validate.dart

Issue 1859343004: dartfmt pkg/compiler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/compiler/lib/src/ssa/types_propagation.dart ('k') | pkg/compiler/lib/src/ssa/value_range_analyzer.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/compiler/lib/src/ssa/validate.dart
diff --git a/pkg/compiler/lib/src/ssa/validate.dart b/pkg/compiler/lib/src/ssa/validate.dart
index 1c1e2225c162768edcf4bde9402f474610e51d22..31e9125648ae388718e7040df5ff788037921b6b 100644
--- a/pkg/compiler/lib/src/ssa/validate.dart
+++ b/pkg/compiler/lib/src/ssa/validate.dart
@@ -22,22 +22,22 @@ class HValidator extends HInstructionVisitor {
// not required to be valid yet.
void visitBasicBlock(HBasicBlock block) {
currentBlock = block;
- if (!isValid) return; // Don't need to continue if we are already invalid.
+ if (!isValid) return; // Don't need to continue if we are already invalid.
// Test that the last instruction is a branching instruction and that the
// basic block contains the branch-target.
if (block.first == null || block.last == null) {
markInvalid("empty block");
}
- if (block.last is !HControlFlow) {
+ if (block.last is! HControlFlow) {
markInvalid("block ends with non-tail node.");
}
if (block.last is HIf && block.successors.length != 2) {
markInvalid("If node without two successors");
}
if (block.last is HConditionalBranch && block.successors.length != 2) {
- markInvalid("Conditional node without two successors");
- }
+ markInvalid("Conditional node without two successors");
+ }
if (block.last is HLoopBranch) {
// Assert that the block we inserted to avoid critical edges satisfies
// our assumptions. That is, it must not contain any instructions
@@ -56,7 +56,7 @@ class HValidator extends HInstructionVisitor {
if ((block.last is HReturn || block.last is HThrow) &&
(block.successors.length != 1 || !block.successors[0].isExitBlock())) {
markInvalid("Return or throw node with > 1 successor "
- "or not going to exit-block");
+ "or not going to exit-block");
}
if (block.last is HExit && !block.successors.isEmpty) {
markInvalid("Exit block with successor");
@@ -77,8 +77,10 @@ class HValidator extends HInstructionVisitor {
}
}
// Make sure we don't have a critical edge.
- if (isValid && block.successors.length > 1 &&
- block.last is! HTry && block.last is! HExitTry &&
+ if (isValid &&
+ block.successors.length > 1 &&
+ block.last is! HTry &&
+ block.last is! HExitTry &&
block.last is! HSwitch) {
for (HBasicBlock successor in block.successors) {
if (!isValid) break;
@@ -131,8 +133,8 @@ class HValidator extends HInstructionVisitor {
}
/** Returns how often [instruction] is contained in [instructions]. */
- static int countInstruction(List<HInstruction> instructions,
- HInstruction instruction) {
+ static int countInstruction(
+ List<HInstruction> instructions, HInstruction instruction) {
int result = 0;
for (int i = 0; i < instructions.length; i++) {
if (identical(instructions[i], instruction)) result++;
@@ -170,8 +172,8 @@ class HValidator extends HInstructionVisitor {
bool inBasicBlock = instruction.isInBasicBlock();
return everyInstruction(instruction.inputs, (input, count) {
if (inBasicBlock) {
- return input.isInBasicBlock()
- && countInstruction(input.usedBy, instruction) == count;
+ return input.isInBasicBlock() &&
+ countInstruction(input.usedBy, instruction) == count;
} else {
return countInstruction(input.usedBy, instruction) == 0;
}
@@ -182,8 +184,8 @@ class HValidator extends HInstructionVisitor {
bool hasCorrectUses() {
if (!instruction.isInBasicBlock()) return true;
return everyInstruction(instruction.usedBy, (use, count) {
- return use.isInBasicBlock()
- && countInstruction(use.inputs, instruction) == count;
+ return use.isInBasicBlock() &&
+ countInstruction(use.inputs, instruction) == count;
});
}
« no previous file with comments | « pkg/compiler/lib/src/ssa/types_propagation.dart ('k') | pkg/compiler/lib/src/ssa/value_range_analyzer.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698