Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Unified Diff: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart

Issue 1859343004: dartfmt pkg/compiler (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
diff --git a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
index 4db23870b62dd0576e5632d4f99e47aa2e807cf8..4bc53840c9c0513f130397c9ef55ac88305f63a5 100644
--- a/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
+++ b/pkg/compiler/lib/src/js_backend/no_such_method_registry.dart
@@ -44,15 +44,19 @@ part of js_backend;
class NoSuchMethodRegistry {
/// The implementations that fall into category A, described above.
final Set<FunctionElement> defaultImpls = new Set<FunctionElement>();
+
/// The implementations that fall into category B, described above.
final Set<FunctionElement> throwingImpls = new Set<FunctionElement>();
+
/// The implementations that fall into category C, described above.
final Set<FunctionElement> notApplicableImpls = new Set<FunctionElement>();
+
/// The implementations that fall into category D, described above.
final Set<FunctionElement> otherImpls = new Set<FunctionElement>();
/// The implementations that fall into category D1
final Set<FunctionElement> complexNoReturnImpls = new Set<FunctionElement>();
+
/// The implementations that fall into category D2
final Set<FunctionElement> complexReturningImpls = new Set<FunctionElement>();
@@ -90,23 +94,20 @@ class NoSuchMethodRegistry {
/// Emits a diagnostic
void emitDiagnostic() {
throwingImpls.forEach((e) {
- if (!_hasForwardingSyntax(e)) {
- reporter.reportHintMessage(
- e, MessageKind.DIRECTLY_THROWING_NSM);
- }
- });
+ if (!_hasForwardingSyntax(e)) {
+ reporter.reportHintMessage(e, MessageKind.DIRECTLY_THROWING_NSM);
+ }
+ });
complexNoReturnImpls.forEach((e) {
- if (!_hasForwardingSyntax(e)) {
- reporter.reportHintMessage(
- e, MessageKind.COMPLEX_THROWING_NSM);
- }
- });
+ if (!_hasForwardingSyntax(e)) {
+ reporter.reportHintMessage(e, MessageKind.COMPLEX_THROWING_NSM);
+ }
+ });
complexReturningImpls.forEach((e) {
- if (!_hasForwardingSyntax(e)) {
- reporter.reportHintMessage(
- e, MessageKind.COMPLEX_RETURNING_NSM);
- }
- });
+ if (!_hasForwardingSyntax(e)) {
+ reporter.reportHintMessage(e, MessageKind.COMPLEX_RETURNING_NSM);
+ }
+ });
}
/// Returns [true] if the given element is a complex [noSuchMethod]
@@ -154,7 +155,7 @@ class NoSuchMethodRegistry {
Element superCall =
element.enclosingClass.lookupSuperByName(Names.noSuchMethod_);
NsmCategory category = _categorizeImpl(superCall);
- switch(category) {
+ switch (category) {
case NsmCategory.DEFAULT:
defaultImpls.add(element);
break;
@@ -183,9 +184,9 @@ class NoSuchMethodRegistry {
bool _isDefaultNoSuchMethodImplementation(FunctionElement element) {
ClassElement classElement = element.enclosingClass;
- return classElement == _compiler.coreClasses.objectClass
- || classElement == _backend.helpers.jsInterceptorClass
- || classElement == _backend.helpers.jsNullClass;
+ return classElement == _compiler.coreClasses.objectClass ||
+ classElement == _backend.helpers.jsInterceptorClass ||
+ classElement == _backend.helpers.jsNullClass;
}
bool _hasForwardingSyntax(FunctionElement element) {
@@ -240,9 +241,4 @@ class NoSuchMethodRegistry {
}
}
-enum NsmCategory {
- DEFAULT,
- THROWING,
- NOT_APPLICABLE,
- OTHER,
-}
+enum NsmCategory { DEFAULT, THROWING, NOT_APPLICABLE, OTHER, }
« no previous file with comments | « pkg/compiler/lib/src/js_backend/native_data.dart ('k') | pkg/compiler/lib/src/js_backend/patch_resolver.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698