Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(209)

Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. (Closed)

Created:
4 years, 8 months ago by erikchen
Modified:
4 years, 8 months ago
CC:
chromium-reviews, asanka, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, grt+watch_chromium.org, chromoting-reviews_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, rginda+watch_chromium.org, rlp+watch_chromium.org, rouslan+spell_chromium.org, groby+spellwatch_chromium.org, darin-cc_chromium.org, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@temp16_ipc_pfft_implementation
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. This CL has no intended behavior change. This CL also removes the now unnecessary parameter |process|. BUG=493414 Committed: https://crrev.com/09b40032d8de63a01eaf62760f2ebc89a813d99c Cr-Commit-Position: refs/heads/master@{#385512}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Comments from tsepez. #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -56 lines) Patch
M chrome/browser/printing/pdf_to_emf_converter.cc View 2 chunks +2 lines, -4 lines 0 comments Download
M chrome/browser/safe_browsing/sandboxed_zip_analyzer.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M chrome/browser/spellchecker/spellcheck_service.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/service/service_utility_process_host.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/nacl/browser/nacl_host_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M components/nacl/browser/nacl_process_host.cc View 2 chunks +6 lines, -7 lines 0 comments Download
M components/nacl/browser/pnacl_host.h View 1 chunk +2 lines, -2 lines 0 comments Download
M components/translate/content/browser/data_file_browser_cld_data_provider.cc View 1 chunk +1 line, -3 lines 0 comments Download
M components/translate/content/common/data_file_cld_data_provider_messages.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/browser_child_process_host_impl.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/browser/download/mhtml_generation_manager.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M content/browser/mojo/mojo_application_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/database_message_filter.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/ppapi_plugin/ppapi_thread.cc View 1 1 chunk +1 line, -2 lines 0 comments Download
M content/public/test/mock_render_process_host.cc View 1 chunk +1 line, -1 line 0 comments Download
M ipc/ipc_platform_file.h View 1 1 chunk +3 lines, -3 lines 0 comments Download
M ipc/ipc_platform_file.cc View 2 chunks +3 lines, -4 lines 0 comments Download
M ppapi/proxy/ppapi_proxy_test.cc View 2 chunks +4 lines, -6 lines 1 comment Download
M remoting/host/daemon_process_win.cc View 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 25 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858973002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858973002/1
4 years, 8 months ago (2016-04-05 01:13:59 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_compile_dbg on tryserver.chromium.android (JOB_TIMED_OUT, https://build.chromium.org/p/tryserver.chromium.android/builders/android_compile_dbg/builds/45227)
4 years, 8 months ago (2016-04-05 07:15:11 UTC) #4
erikchen
tsepez: Please review.
4 years, 8 months ago (2016-04-05 17:28:44 UTC) #8
Tom Sepez
lgtm https://codereview.chromium.org/1858973002/diff/1/ipc/ipc_platform_file.h File ipc/ipc_platform_file.h (right): https://codereview.chromium.org/1858973002/diff/1/ipc/ipc_platform_file.h#newcode59 ipc/ipc_platform_file.h:59: // passed to the IPC stack, or else ...
4 years, 8 months ago (2016-04-05 17:45:06 UTC) #9
erikchen
https://codereview.chromium.org/1858973002/diff/1/ipc/ipc_platform_file.h File ipc/ipc_platform_file.h (right): https://codereview.chromium.org/1858973002/diff/1/ipc/ipc_platform_file.h#newcode59 ipc/ipc_platform_file.h:59: // passed to the IPC stack, or else it ...
4 years, 8 months ago (2016-04-05 19:25:33 UTC) #10
erikchen
thestig: Please review chrome/ mseaborn: Please review components/nacl droger: Please review components/translate avi: Please review ...
4 years, 8 months ago (2016-04-05 19:28:36 UTC) #12
piman
lgtm
4 years, 8 months ago (2016-04-05 19:37:19 UTC) #13
Sergey Ulanov
lgtm
4 years, 8 months ago (2016-04-05 19:38:56 UTC) #14
Mark Seaborn
LGTM for components/nacl/ https://codereview.chromium.org/1858973002/diff/20001/ppapi/proxy/ppapi_proxy_test.cc File ppapi/proxy/ppapi_proxy_test.cc (right): https://codereview.chromium.org/1858973002/diff/20001/ppapi/proxy/ppapi_proxy_test.cc#newcode257 ppapi/proxy/ppapi_proxy_test.cc:257: should_close_source); Nit: fits on previous line?
4 years, 8 months ago (2016-04-05 19:40:38 UTC) #15
Lei Zhang
chrome/ lgtm
4 years, 8 months ago (2016-04-05 20:37:29 UTC) #16
droger
lgtm
4 years, 8 months ago (2016-04-06 13:52:15 UTC) #17
Avi (use Gerrit)
lgtm
4 years, 8 months ago (2016-04-06 16:46:01 UTC) #18
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1858973002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1858973002/20001
4 years, 8 months ago (2016-04-06 17:29:30 UTC) #21
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 8 months ago (2016-04-06 18:52:08 UTC) #23
commit-bot: I haz the power
4 years, 8 months ago (2016-04-06 18:53:58 UTC) #25
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/09b40032d8de63a01eaf62760f2ebc89a813d99c
Cr-Commit-Position: refs/heads/master@{#385512}

Powered by Google App Engine
This is Rietveld 408576698