Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Unified Diff: components/nacl/browser/nacl_process_host.cc

Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp16_ipc_pfft_implementation
Patch Set: Comments from tsepez. Created 4 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/nacl/browser/nacl_process_host.cc
diff --git a/components/nacl/browser/nacl_process_host.cc b/components/nacl/browser/nacl_process_host.cc
index 35c061596fa4837b8f35e1bcf7c56771f516dff5..8a3abb82bc52133667bf6d6ca200a78ba5854400 100644
--- a/components/nacl/browser/nacl_process_host.cc
+++ b/components/nacl/browser/nacl_process_host.cc
@@ -883,12 +883,11 @@ bool NaClProcessHost::StartNaClExecution() {
params.version = NaClBrowser::GetDelegate()->GetVersionString();
params.enable_debug_stub = enable_nacl_debug;
- const ChildProcessData& data = process_->GetData();
const base::File& irt_file = nacl_browser->IrtFile();
CHECK(irt_file.IsValid());
// Send over the IRT file handle. We don't close our own copy!
- params.irt_handle = IPC::GetFileHandleForProcess(
- irt_file.GetPlatformFile(), data.handle, false);
+ params.irt_handle = IPC::GetPlatformFileForTransit(
+ irt_file.GetPlatformFile(), false);
if (params.irt_handle == IPC::InvalidPlatformFileForTransit()) {
return false;
}
@@ -918,16 +917,16 @@ bool NaClProcessHost::StartNaClExecution() {
DLOG(ERROR) << "Failed to dup() a file descriptor";
return false;
}
- params.mac_shm_fd = IPC::GetFileHandleForProcess(
- memory_fd.release(), data.handle, true);
+ params.mac_shm_fd = IPC::GetPlatformFileForTransit(
+ memory_fd.release(), true);
#endif
#if defined(OS_POSIX)
if (params.enable_debug_stub) {
net::SocketDescriptor server_bound_socket = GetDebugStubSocketHandle();
if (server_bound_socket != net::kInvalidSocket) {
- params.debug_stub_server_bound_socket = IPC::GetFileHandleForProcess(
- server_bound_socket, data.handle, true);
+ params.debug_stub_server_bound_socket = IPC::GetPlatformFileForTransit(
+ server_bound_socket, true);
}
}
#endif

Powered by Google App Engine
This is Rietveld 408576698