ppapi/proxy/ppapi_proxy_test.cc - Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ppapi/proxy/ppapi_proxy_test.cc

Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp16_ipc_pfft_implementation

Patch Set: Comments from tsepez. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ppapi/proxy/ppapi_proxy_test.cc

diff --git a/ppapi/proxy/ppapi_proxy_test.cc b/ppapi/proxy/ppapi_proxy_test.cc

index 5ff1a4e8186cf2dd3fbad78223a9a5a55cbda18d..88bf5dba70a5ece40e3dd24c6c07217eac43c4c4 100644

--- a/ppapi/proxy/ppapi_proxy_test.cc

+++ b/ppapi/proxy/ppapi_proxy_test.cc

@@ -253,9 +253,8 @@ PluginProxyTestHarness::PluginDelegateMock::ShareHandleWithRemote(

base::PlatformFile handle,

base::ProcessId /* remote_pid */,

bool should_close_source) {

- return IPC::GetFileHandleForProcess(handle,

- base::GetCurrentProcessHandle(),

- should_close_source);

+ return IPC::GetPlatformFileForTransit(handle,

+ should_close_source);

Mark Seaborn 2016/04/05 19:40:38 Nit: fits on previous line?

}

base::SharedMemoryHandle

@@ -491,9 +490,8 @@ HostProxyTestHarness::DelegateMock::ShareHandleWithRemote(