components/translate/content/browser/data_file_browser_cld_data_provider.cc - Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/translate/content/browser/data_file_browser_cld_data_provider.cc

Issue 1858973002: ipc: Rename GetFileHandleForProcess->GetPlatformFileForTransit. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@temp16_ipc_pfft_implementation

Patch Set: Comments from tsepez. Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/nacl/browser/pnacl_host.h ('k') | components/translate/content/common/data_file_cld_data_provider_messages.h » ('j') | ppapi/proxy/ppapi_proxy_test.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/translate/content/browser/data_file_browser_cld_data_provider.cc

diff --git a/components/translate/content/browser/data_file_browser_cld_data_provider.cc b/components/translate/content/browser/data_file_browser_cld_data_provider.cc

index dcfe4cee3ac86311bd3913fe0b1e9a2507b5c6b8..ca658036af9530c0b0d032d425430cdb735ebfab 100644

--- a/components/translate/content/browser/data_file_browser_cld_data_provider.cc

+++ b/components/translate/content/browser/data_file_browser_cld_data_provider.cc

@@ -160,10 +160,8 @@ void DataFileBrowserCldDataProvider::SendCldDataResponseInternal(

}

// Data available, respond to the request.

- base::ProcessHandle render_process_handle = render_process_host->GetHandle();

IPC::PlatformFileForTransit ipc_platform_file =

- IPC::GetFileHandleForProcess(handle->GetPlatformFile(),

- render_process_handle, false);

+ IPC::GetPlatformFileForTransit(handle->GetPlatformFile(), false);

// In general, sending a response from within the code path that is processing

// a request is discouraged because there is potential for deadlock (if the