Rename GetCStr and GetPtr to match CFX_ByteString

Rename GetCStr and GetPtr to match CFX_ByteString.

This CL updates CFX_ByteStringC to use the more common c_str 
and raw_str instead of GetCStr and GetPtr.

Committed: https://pdfium.googlesource.com/pdfium/+/179bebb9a14dfd3ba91e9e068d4d436657a7c780

[dsinclair, 2016-04-04 17:07:06]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2016-04-04 17:07:07]

PTAL.

[Tom Sepez, 2016-04-04 18:22:40]

lgtm

Is there a wide equivalent?

https://codereview.chromium.org/1857713003/diff/1/core/fxcrt/include/fx_string.h
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/1857713003/diff/1/core/fxcrt/include/fx_strin...
core/fxcrt/include/fx_string.h:96: const FX_CHAR* c_str() const { return (const
FX_CHAR*)m_Ptr; }
nit: reinterpret cast.

[dsinclair, 2016-04-04 18:31:22]

Description was changed from

==========
Rename GetCStr to c_str.

This CL upldates CFX_ByteStringC to use the more common c_str instead of
GetCStr.
==========

to

==========
Rename GetCStr and GetPtr to match CFX_ByteString.

This CL updates CFX_ByteStringC to use the more common c_str 
and raw_str instead of GetCStr and GetPtr.
==========

[dsinclair, 2016-04-04 18:33:34]

I didn't see a WChar version, but I did notice that GetPtr should be raw_str to
better match CFX_ByteString. PTAL.

https://codereview.chromium.org/1857713003/diff/1/core/fxcrt/include/fx_string.h
File core/fxcrt/include/fx_string.h (right):

https://codereview.chromium.org/1857713003/diff/1/core/fxcrt/include/fx_strin...
core/fxcrt/include/fx_string.h:96: const FX_CHAR* c_str() const { return (const
FX_CHAR*)m_Ptr; }
On 2016/04/04 18:22:40, Tom Sepez wrote:
> nit: reinterpret cast.

Done.

[Tom Sepez, 2016-04-05 17:17:57]

lgtm

[dsinclair, 2016-04-05 17:19:21]

The CQ bit was checked by dsinclair@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:19:28]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857713003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857713003/20001

[commit-bot: I haz the power, 2016-04-05 17:30:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-04-05 17:30:26]

Try jobs failed on following builders:
  linux_no_v8 on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/linux_no_v8/bui...)
  win on master.tryserver.client.pdfium (JOB_FAILED,
https://build.chromium.org/p/tryserver.client.pdfium/builders/win/builds/100)

[dsinclair, 2016-04-05 17:38:41]

The CQ bit was checked by dsinclair@chromium.org

[dsinclair, 2016-04-05 17:38:42]

The patchset sent to the CQ was uploaded after l-g-t-m from tsepez@chromium.org
Link to the patchset: https://codereview.chromium.org/1857713003/#ps40001
(title: "Rebase to master")

[commit-bot: I haz the power, 2016-04-05 17:38:46]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1857713003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1857713003/40001

[commit-bot: I haz the power, 2016-04-05 18:02:21]

Description was changed from

==========
Rename GetCStr and GetPtr to match CFX_ByteString.

This CL updates CFX_ByteStringC to use the more common c_str 
and raw_str instead of GetCStr and GetPtr.
==========

to

==========
Rename GetCStr and GetPtr to match CFX_ByteString.

This CL updates CFX_ByteStringC to use the more common c_str 
and raw_str instead of GetCStr and GetPtr.

Committed:
https://pdfium.googlesource.com/pdfium/+/179bebb9a14dfd3ba91e9e068d4d436657a7...
==========

[commit-bot: I haz the power, 2016-04-05 18:02:22]

Committed patchset #3 (id:40001) as
https://pdfium.googlesource.com/pdfium/+/179bebb9a14dfd3ba91e9e068d4d436657a7...