Rename GetCStr and GetPtr to match CFX_ByteString

xfa/fxjse/value.cpp

 // Copyright 2014 PDFium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // Original code copyright 2014 Foxit Software Inc. http://www.foxitsoftware.com
 
 #include "xfa/fxjse/value.h"
 
 #include <math.h>
 
@@ skipping 231 matching lines @@
       reinterpret_cast<CFXJSE_Value*>(hValue)->GetIsolate());
 }
 
 void FXJSE_ThrowMessage(const CFX_ByteStringC& utf8Name,
                         const CFX_ByteStringC& utf8Message) {
   v8::Isolate* pIsolate = v8::Isolate::GetCurrent();
   ASSERT(pIsolate);
 
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(pIsolate);
   v8::Local<v8::String> hMessage = v8::String::NewFromUtf8(
-      pIsolate, utf8Message.GetCStr(), v8::String::kNormalString,
+      pIsolate, utf8Message.c_str(), v8::String::kNormalString,
       utf8Message.GetLength());
   v8::Local<v8::Value> hError;
 
   if (utf8Name == "RangeError") {
     hError = v8::Exception::RangeError(hMessage);
   } else if (utf8Name == "ReferenceError") {
     hError = v8::Exception::ReferenceError(hMessage);
   } else if (utf8Name == "SyntaxError") {
     hError = v8::Exception::SyntaxError(hMessage);
   } else if (utf8Name == "TypeError") {
     hError = v8::Exception::TypeError(hMessage);
   } else {
     hError = v8::Exception::Error(hMessage);
     if (utf8Name != "Error" && !utf8Name.IsEmpty()) {
       hError.As<v8::Object>()->Set(
           v8::String::NewFromUtf8(pIsolate, "name"),
-          v8::String::NewFromUtf8(pIsolate, utf8Name.GetCStr(),
+          v8::String::NewFromUtf8(pIsolate, utf8Name.c_str(),
                                   v8::String::kNormalString,
                                   utf8Name.GetLength()));
     }
   }
   pIsolate->ThrowException(hError);
 }
 
 CFXJSE_Value* CFXJSE_Value::Create(v8::Isolate* pIsolate) {
   return new CFXJSE_Value(pIsolate);
 }
@@ skipping 91 matching lines @@
                                         CFXJSE_Value* lpPropValue) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   if (!hObject->IsObject())
     return FALSE;
 
   v8::Local<v8::Value> hPropValue =
       v8::Local<v8::Value>::New(m_pIsolate, lpPropValue->DirectGetValue());
   return (FX_BOOL)hObject.As<v8::Object>()->Set(
-      v8::String::NewFromUtf8(m_pIsolate, szPropName.GetCStr(),
+      v8::String::NewFromUtf8(m_pIsolate, szPropName.c_str(),
                               v8::String::kNormalString,
                               szPropName.GetLength()),
       hPropValue);
 }
 
 FX_BOOL CFXJSE_Value::GetObjectProperty(const CFX_ByteStringC& szPropName,
                                         CFXJSE_Value* lpPropValue) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   if (!hObject->IsObject())
     return FALSE;
 
   v8::Local<v8::Value> hPropValue =
       hObject.As<v8::Object>()->Get(v8::String::NewFromUtf8(
-          m_pIsolate, szPropName.GetCStr(), v8::String::kNormalString,
+          m_pIsolate, szPropName.c_str(), v8::String::kNormalString,
           szPropName.GetLength()));
   lpPropValue->ForceSetValue(hPropValue);
   return TRUE;
 }
 
 FX_BOOL CFXJSE_Value::SetObjectProperty(uint32_t uPropIdx,
                                         CFXJSE_Value* lpPropValue) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
@@ skipping 19 matching lines @@
 }
 
 FX_BOOL CFXJSE_Value::DeleteObjectProperty(const CFX_ByteStringC& szPropName) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   if (!hObject->IsObject())
     return FALSE;
 
   hObject.As<v8::Object>()->Delete(v8::String::NewFromUtf8(
-      m_pIsolate, szPropName.GetCStr(), v8::String::kNormalString,
+      m_pIsolate, szPropName.c_str(), v8::String::kNormalString,
       szPropName.GetLength()));
   return TRUE;
 }
 
 FX_BOOL CFXJSE_Value::HasObjectOwnProperty(const CFX_ByteStringC& szPropName,
                                            FX_BOOL bUseTypeGetter) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   if (!hObject->IsObject())
     return FALSE;
 
   v8::Local<v8::String> hKey = v8::String::NewFromUtf8(
-      m_pIsolate, szPropName.GetCStr(), v8::String::kNormalString,
+      m_pIsolate, szPropName.c_str(), v8::String::kNormalString,
       szPropName.GetLength());
   return hObject.As<v8::Object>()->HasRealNamedProperty(hKey) ||
          (bUseTypeGetter &&
           hObject.As<v8::Object>()
               ->HasOwnProperty(m_pIsolate->GetCurrentContext(), hKey)
               .FromMaybe(false));
 }
 
 FX_BOOL CFXJSE_Value::SetObjectOwnProperty(const CFX_ByteStringC& szPropName,
                                            CFXJSE_Value* lpPropValue) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> hObject =
       v8::Local<v8::Value>::New(m_pIsolate, m_hValue);
   if (!hObject->IsObject())
     return FALSE;
 
   v8::Local<v8::Value> hValue =
       v8::Local<v8::Value>::New(m_pIsolate, lpPropValue->m_hValue);
   return hObject.As<v8::Object>()
       ->DefineOwnProperty(
           m_pIsolate->GetCurrentContext(),
-          v8::String::NewFromUtf8(m_pIsolate, szPropName.GetCStr(),
+          v8::String::NewFromUtf8(m_pIsolate, szPropName.c_str(),
                                   v8::String::kNormalString,
                                   szPropName.GetLength()),
           hValue)
       .FromMaybe(false);
 }
 
 FX_BOOL CFXJSE_Value::SetFunctionBind(CFXJSE_Value* lpOldFunction,
                                       CFXJSE_Value* lpNewThis) {
   CFXJSE_ScopeUtil_IsolateHandleRootContext scope(m_pIsolate);
   v8::Local<v8::Value> rgArgs[2];
@@ skipping 89 matching lines @@
   if (lpRetValue)
     lpRetValue->ForceSetValue(hReturnValue);
 
   if (lpLocalArgs) {
     for (uint32_t i = 0; i < nArgCount; i++)
       lpLocalArgs[i].~Local();
     FX_Free(lpLocalArgs);
   }
   return bRetValue;
 }