core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp - Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp

Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase to master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp

diff --git a/core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp b/core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp

index 67287dfd5a445962578f4ce43ebf3f8fdbccf88e..db3ccf5e3dc9b2908b1d60e48b30e5f023791633 100644

--- a/core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp

+++ b/core/fpdfapi/fpdf_parser/cpdf_simple_parser_unittest.cpp

@@ -54,7 +54,7 @@ TEST(SimpleParserTest, GetWord) {

CFX_ByteStringC word = parser.GetWord();

EXPECT_EQ(std::string(reinterpret_cast<const char*>(data.expected),

data.expected_size),

- std::string(word.GetCStr(), word.GetLength()))

+ std::string(word.c_str(), word.GetLength()))

<< " for case " << i;

}