xfa/fxjse/value.h - Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: xfa/fxjse/value.h

Issue 1857713003: Rename GetCStr and GetPtr to match CFX_ByteString (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Rebase to master Created 4 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: xfa/fxjse/value.h

diff --git a/xfa/fxjse/value.h b/xfa/fxjse/value.h

index e728b8d85732ce7740136c0eaff243d75ae02189..2939ac34f7cd362797132d4743d0db9418cd22c2 100644

--- a/xfa/fxjse/value.h

+++ b/xfa/fxjse/value.h

@@ -180,7 +180,7 @@ class CFXJSE_Value {

V8_INLINE void SetString(const CFX_ByteStringC& szString) {

CFXJSE_ScopeUtil_IsolateHandle scope(m_pIsolate);

v8::Local<v8::Value> hValue = v8::String::NewFromUtf8(

- m_pIsolate, reinterpret_cast<const char*>(szString.GetPtr()),

+ m_pIsolate, reinterpret_cast<const char*>(szString.raw_str()),

v8::String::kNormalString, szString.GetLength());

m_hValue.Reset(m_pIsolate, hValue);

}

« no previous file with comments | « xfa/fxjse/dynprop.cpp ('k') | xfa/fxjse/value.cpp » ('j') | no next file with comments »